Open
Conversation
benbjohnson
requested changes
Mar 21, 2024
Comment on lines
193
to
195
| for k, v := range metadata { | ||
| params += fmt.Sprintf("metadata.%s=%s", k, v) | ||
| } |
Collaborator
There was a problem hiding this comment.
This isn't separating out URL parameters with a &. A better approach would be to just use url.Values so it can handle encoding too. Also,it doesn't look like state is even used by any of the callers of List() so you could just remove it.
q := make(url.Values)
for k, v := range metadata {
q.Set("metadata." + k, v)
}
var getEndpoint = ""
if len(q) > 0 {
getEndpoint = "?" + q.Encode()
}
benbjohnson
approved these changes
Mar 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.