Fix : postgres backup config reset #4507
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add support for downloading Dockerfiles from URLs (http/https) - Fix issue where URLs were treated as local paths and concatenated with working directory - Add URL detection and download functionality in resolveDockerfilePath - Update dockerfile_builder to handle temporary files from downloaded URLs - Add comprehensive unit tests for URL handling and download functionality Fixes superfly#4464
- Add backup detection logic to check for S3_ARCHIVE_CONFIG secret before image updates - Display warning message when backups are detected on postgres apps during image update - Inform users to run 'fly secrets deploy' to restore backup configuration after update - Add comprehensive unit tests for backup detection functionality Fixes superfly#4340
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
What and Why:
Fixed PostgreSQL backup configurations being reset after
fly image update. The issue occurred because backup settings stored in theS3_ARCHIVE_CONFIGsecret were not preserved during image updates, causing backup functionality to revert to default values and potentially disrupting backup schedules.How:
isBackupEnabled()function to detect backup-enabled PostgreSQL apps by checking forS3_ARCHIVE_CONFIGsecretupdatePostgresOnMachines()to check backup status before performing image updatesbackup_config_test.goRelated to:
Fixes #4340
Documentation