Merged
Conversation
saleemrashid
force-pushed
the
saleem/sidecar
branch
from
662e569 to
b8f4eea
Compare
saleemrashid
force-pushed
the
saleem/sidecar
branch
2 times, most recently
from
9879f47 to
ea27cac
Compare
saleemrashid
force-pushed
the
saleem/sidecar
branch
from
ea27cac to
221f091
Compare
benbjohnson
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for using the LiteFS container as a sidecar, when used in a container runtime that supports mount propagation (e.g. filesystems mounted inside one container can be propagated to the host or other containers).
fusermount3binary-skip-unmountargument tolitefs mount, and uses that as the container command. When mounting on top of an existing mountpoint, LiteFS would unconditionally unmount it. This would break mount propagation, so we want to avoid this behavior.Fixes #365