-
Notifications
You must be signed in to change notification settings - Fork 1
Add LinkCard components for related documentation sections #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace plain markdown link lists with interactive spotlight cards across all documentation pages. Cards feature icons, titles, descriptions, and a spotlight hover effect. - Add SpotlightCard, LinkCard, and CardGrid components - Update all 17 documentation pages with card-based navigation - Add Cypress tests for card rendering and navigation - Cards are theme-aware and use primary color from CSS variables 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Preview Deployment
Commit: |
The new LinkCard components were being stripped from the markdown output. Added regex handler to convert CardGrid/LinkCard JSX to plain markdown link lists for the .md endpoint. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
E2E Test Results✅ Tests success Ran against: https://pr-32-superfly-sprites-docs.fly.dev |
- Add assertion that href is an internal link
- Use cy.location('pathname') instead of cy.url() to avoid
waiting for full page load event
- Increase timeout to 60s for slow CI environments
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <[email protected]>
Clicking links triggers full page load which times out in CI. Using cy.request() to verify the linked page exists (returns 200) is faster and more reliable. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
pnpm build)pnpm lint)pnpm test:e2e)🤖 Generated with Claude Code