Fix accessibility issues in SearchDialog component #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Add proper ARIA dialog attributes (role, aria-modal, aria-label) - Implement combobox pattern with listbox for search results - Add aria-label to search input and clear button - Hide decorative elements from screen readers (SVGs, gradients, kbd hints) - Add live region for search status announcements - Implement focus trap for modal accessibility - Extend AnimatedItem to support accessibility props 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Preview Deployment
Commit: |
E2E Test Results✅ Tests success Ran against: https://pr-35-superfly-sprites-docs.fly.dev |
Wrap green gradient backgrounds and image overlay in media queries to only display on screens >= 768px, improving mobile performance. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
role="dialog",aria-modal,aria-label) to the search modalaria-hidden<output>witharia-live) for search status announcementsAnimatedItemcomponent to accept accessibility props (role,id,aria-selected,tabIndex)Test plan
aria-activedescendantupdates🤖 Generated with Claude Code