Skip to content

Track pods by UID instead of only namespace/name#8

Open
saleemrashid wants to merge 25 commits intoupstreamfrom
saleem/pod-uid
Open

Track pods by UID instead of only namespace/name#8
saleemrashid wants to merge 25 commits intoupstreamfrom
saleem/pod-uid

Conversation

@saleemrashid
Copy link
Member

@saleemrashid saleemrashid commented Apr 26, 2025

No description provided.

@saleemrashid saleemrashid changed the base branch from master to upstream April 26, 2025 11:22
@saleemrashid saleemrashid reopened this Apr 26, 2025
@saleemrashid saleemrashid force-pushed the saleem/pod-uid branch 6 times, most recently from 211ddda to 339b787 Compare April 26, 2025 13:36
senyosimpson
senyosimpson approved these changes Apr 29, 2025
View reviewed changes
Copy link
Member

@senyosimpson senyosimpson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

node/podcontroller.go
// concurrently outside of the calling goroutine. Therefore it is recommended
// to return a version after DeepCopy.
GetPods(context.Context) ([]*corev1.Pod, error)
GetPodByUID(ctx context.Context, namespace, name string, uid types.UID) (*corev1.Pod, error)
Copy link
Member

@senyosimpson senyosimpson Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why don't we just add these to the PodLifecycleHandler directly? or do you want some type safety against calling GetPods/GetPodStatus?

Copy link
Member Author

@saleemrashid saleemrashid Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the type safety. I want this to be backwards-compatible (I'm going to see if we can get it upstreamed), but I also don't want the old methods to be accidentally called internally.

thevilledev and others added 20 commits May 29, 2025 17:44
@thevilledev @pires
fix: enable lll linter and format long function signatures
ca78265 
Previously lll linter was configured to .golangci.yml but with
a typo in the directive ('linter-settings', not 'linters-settings').

Enable line length linter and fix long lines by breaking function
signatures across multiple lines in exec.go, attach.go, and resource.go.

Signed-off-by: Ville Vesilehto <ville@vesilehto.fi>
@pires
ci: revisit Go linter
dd685be
@galal-hussein @pires
Check for EphemeralContainers changes in pod compare
0a453f9 
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
@dependabot @pires
build(deps): bump golang.org/x/net from 0.34.0 to 0.38.0
65f6275 
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.34.0 to 0.38.0.
- [Commits](golang/net@v0.34.0...v0.38.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-version: 0.38.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @pires
build(deps): bump github.com/prometheus/common from 0.61.0 to 0.63.0
c9f64e8 
Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.61.0 to 0.63.0.
- [Release notes](https://github.com/prometheus/common/releases)
- [Changelog](https://github.com/prometheus/common/blob/main/RELEASE.md)
- [Commits](prometheus/common@v0.61.0...v0.63.0)

---
updated-dependencies:
- dependency-name: github.com/prometheus/common
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@enrichman @pires
added envtest
4ce429e
@dependabot @pires
build(deps): bump go.opentelemetry.io/otel from 1.33.0 to 1.36.0
adde4a8 
Bumps [go.opentelemetry.io/otel](https://github.com/open-telemetry/opentelemetry-go) from 1.33.0 to 1.36.0.
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go@v1.33.0...v1.36.0)

---
updated-dependencies:
- dependency-name: go.opentelemetry.io/otel
  dependency-version: 1.36.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @pires
build(deps): bump go.opentelemetry.io/otel/sdk from 1.33.0 to 1.36.0
84502b7 
Bumps [go.opentelemetry.io/otel/sdk](https://github.com/open-telemetry/opentelemetry-go) from 1.33.0 to 1.36.0.
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go@v1.33.0...v1.36.0)

---
updated-dependencies:
- dependency-name: go.opentelemetry.io/otel/sdk
  dependency-version: 1.36.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@tskillian @pires
Fix potential NPE on pod status updates
44fa1bc
@dependabot @pires
build(deps): bump sigs.k8s.io/controller-runtime from 0.19.4 to 0.22.1
7b6f50c 
Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from 0.19.4 to 0.22.1.
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md)
- [Commits](kubernetes-sigs/controller-runtime@v0.19.4...v0.22.1)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/controller-runtime
  dependency-version: 0.22.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @pires
build(deps): bump actions/checkout from 4 to 5
7d09c07 
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v4...v5)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: '5'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @pires
build(deps): bump golang.org/x/sync from 0.14.0 to 0.17.0
8026f0f 
Bumps [golang.org/x/sync](https://github.com/golang/sync) from 0.14.0 to 0.17.0.
- [Commits](golang/sync@v0.14.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sync
  dependency-version: 0.17.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@twelho @pires
fix: do not register nil loggers
1595a69 
`nopSpan.Logger()` passes in `nil` into `log.WithLogger` any time `trace.StartSpan` is invoked, which overrides the logger from an externally provided context. This inadvertently suppresses all logging for the span, including for errors. Prevent clearing the existing logger here if, for example, `trace.StartSpan` does not pass in a new one. To use the default logger again, invoke `log.WithLogger` with `log.L` explicitly.

Signed-off-by: Dennis Marttinen <twelho@welho.tech>
@pires
ci: bump Kubernetes to v1.33 and Go to 1.24
c1efbd1
@dependabot @pires
build(deps): bump go.opentelemetry.io/otel/sdk from 1.36.0 to 1.38.0
a4ecc3e 
Bumps [go.opentelemetry.io/otel/sdk](https://github.com/open-telemetry/opentelemetry-go) from 1.36.0 to 1.38.0.
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go@v1.36.0...v1.38.0)

---
updated-dependencies:
- dependency-name: go.opentelemetry.io/otel/sdk
  dependency-version: 1.38.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @pires
build(deps): bump golang.org/x/time from 0.9.0 to 0.13.0
2456b12 
Bumps [golang.org/x/time](https://github.com/golang/time) from 0.9.0 to 0.13.0.
- [Commits](golang/time@v0.9.0...v0.13.0)

---
updated-dependencies:
- dependency-name: golang.org/x/time
  dependency-version: 0.13.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @pires
build(deps): bump k8s.io/kubelet from 0.31.4 to 0.34.0
2a49e3a 
Bumps [k8s.io/kubelet](https://github.com/kubernetes/kubelet) from 0.31.4 to 0.34.0.
- [Commits](kubernetes/kubelet@v0.31.4...v0.34.0)

---
updated-dependencies:
- dependency-name: k8s.io/kubelet
  dependency-version: 0.34.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @pires
build(deps): bump github.com/spf13/pflag from 1.0.6 to 1.0.10
811c028 
Bumps [github.com/spf13/pflag](https://github.com/spf13/pflag) from 1.0.6 to 1.0.10.
- [Release notes](https://github.com/spf13/pflag/releases)
- [Commits](spf13/pflag@v1.0.6...v1.0.10)

---
updated-dependencies:
- dependency-name: github.com/spf13/pflag
  dependency-version: 1.0.10
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@pires
deps: fix Prometheus bump proposed by dependabot
c485b29
@saleemrashid
queue: Use generic key type
40cc429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@senyosimpson senyosimpson senyosimpson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@saleemrashid @senyosimpson @thevilledev @pires @galal-hussein @enrichman @tskillian @twelho