-
Notifications
You must be signed in to change notification settings - Fork 0
Readme #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readme #1
Conversation
Add Dashboard API key link and accuracy policy, point API reference to canonical OpenAPI spec, and add basic CI (docs.json validation + link check + staging guard).
WalkthroughThis PR rebrands docs to Supermodel, replaces staging URLs with production endpoints across MDX files, adds a GitHub Actions CI workflow for JSON validation and link-checking, updates docs.json config, and introduces extensive dark-mode CSS overrides. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Developer
participant GitHub as "GitHub Actions"
participant Repo as "Repository"
participant jq as "jq (JSON validator)"
participant rg as "rg (regex check)"
participant Lychee as "lychee-action (link checker)"
Developer->>GitHub: push / open PR
GitHub->>Repo: checkout code
GitHub->>jq: validate docs.json
jq-->>GitHub: pass/fail
GitHub->>rg: scan for staging URLs
rg-->>GitHub: pass/fail
GitHub->>Lychee: run link checks on README.md + **/*.mdx
Lychee-->>GitHub: report results
GitHub-->>Developer: CI pass/fail status
rect rgba(0,128,0,0.06)
note right of GitHub: Success path
end
rect rgba(255,0,0,0.06)
note right of GitHub: Failure path (fails CI)
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
Pre-merge checks❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
overrides.css (1)
1-37: Consider removing duplicate CSS rules.There's some duplication in the dark mode overrides that could be cleaned up:
- Lines 1-5 are duplicated at lines 28-32 (
:rootvariables)- Lines 7-10 are duplicated at lines 34-37 (
html.dark, body.dark, .darkrules)- Lines 12-18 overlap with lines 40-45 (
.dark .bg-background-*rules)This doesn't break anything since CSS just uses the last declaration, but removing the duplicates would make the file easier to maintain.
🔎 Suggested cleanup
You can remove lines 1-37 entirely since lines 39-135 already cover all the same rules plus additional ones. The duplicate declarations at the top appear to be leftover from development.
-:root { - --bg-dark: #000000 !important; - --bg-default: #000000 !important; - --bg-background-dark: #000000 !important; -} - -html.dark, body.dark, .dark { - background-color: #000000 !important; - --tw-ring-offset-color: #000000 !important; -} - -.dark .bg-background-dark { - background-color: #000000 !important; -} - -.dark .bg-background-light { - background-color: #000000 !important; -} - -.dark main { - background-color: #000000 !important; -} - -.dark nav, .dark aside { - background-color: #000000 !important; - border-right-color: #1F1F1F !important; -} -:root { - --bg-dark: #000000 !important; - --bg-default: #000000 !important; - --bg-background-dark: #000000 !important; -} - -html.dark, body.dark, .dark { - background-color: #000000 !important; - --tw-ring-offset-color: #000000 !important; -} - /* Force black on all major layout containers */ .dark .bg-background-dark { background-color: #000000 !important;Then add the
:rootdeclaration once at the top if it's not already there below line 37..github/workflows/ci.yml (2)
19-24: Consider edge cases for the staging URL guard.The regex pattern
staging\\.will catch obvious staging URLs likestaging.supermodeltools.com, which is great. However, just a heads up on potential edge cases:
- It won't catch staging URLs without a subdomain (like
supermodelstaging.comor paths likeexample.com/staging/api)- It might flag legitimate uses of the word "staging" in documentation text
If you have specific staging URL patterns to guard against, you could make the pattern more precise. For example, if all your staging URLs follow the pattern
staging.supermodeltools.com, you could use:if rg -n "staging\\.supermodeltools\\.com" .; thenThis reduces false positives while still catching the URLs you care about.
26-36: HTTP 429 acceptance could hide broken links.The link checker accepts
429(Too Many Requests) as a valid response. While this prevents CI from breaking when external servers rate-limit you, it creates a blind spot: if you accidentally typo a URL (likeapi.example.com/v1/usresinstead of/users), and the server rate-limits before returning a 404, the check will pass even though the link is actually broken.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
.github/workflows/ci.ymlREADME.mdauthentication.mdxdocs.jsonindex.mdxoverrides.cssquickstart.mdx
🔇 Additional comments (8)
docs.json (3)
58-58: Dashboard URL update is consistent.This matches the production URL migration pattern across all documentation files.
63-64: Social media links check out. Both the X and GitHub profiles are live and accessible (HTTP 200). No action needed.
40-40: No action needed—OpenAPI spec URL is accessible and valid.The URL at line 40 is publicly accessible and returns valid OpenAPI 3.0.0 YAML content.
authentication.mdx (1)
7-7: Authentication docs updated consistently.All three URL updates follow the same production migration pattern seen throughout the PR. The authentication flow documentation now correctly points users to the production dashboard and API endpoints.
Also applies to: 10-10, 40-40
quickstart.mdx (1)
11-11: Good to go on the production URLs.The dashboard link and API endpoint are both using the right production domains (
dashboard.supermodeltools.comandapi.supermodeltools.com). Users following this quickstart will hit the real services, not any staging or test endpoints. Clean and ready.index.mdx (1)
11-11: Dashboard URL is correct and consistent with the codebase.The link to
https://dashboard.supermodeltools.com/matches the official production dashboard URL used throughout the documentation (authentication.mdx, quickstart.mdx, README.md, and docs.json). This is the right reference for users to get their API key..github/workflows/ci.yml (1)
1-17: Nice workflow structure!The CI setup is clean and well-organized. The three validation steps (JSON validation, staging URL guard, link checking) are logically separated and easy to understand. The JSON validation using
jqis a simple and effective way to catch malformed config files early.README.md (1)
35-39: No changes needed—mintis the official Mintlify CLI package.The package name is actually correct. Mintlify's CLI is published to npm as simply
mint(not a scoped package like@mintlify/cli). This is the official package, sonpm i -g mintis the right command.
…from .github/workflows/ci.yml. lychee v0.21.0 doesn’t recognize it (it only has --include-mail), so this should unblock the link check without changing anything else.
Summary by CodeRabbit
New Features
Documentation
Chores
✏️ Tip: You can customize this high-level summary in your review settings.