Merged
Conversation
- Adjusted button styles in `button.tsx` for better visual consistency. - Updated background color variables in `index.css` for light mode. - Enhanced table border styles in `CanvasMemoryView.tsx` for better visibility. - Refined layout and styling in `CanvasSettingsView.tsx` and `CanvasYamlView.tsx` for improved user experience. - Removed deprecated `CliCommandsPopover` component and adjusted related references in the header and canvas page components. - Introduced new CLI view mode in the workflow page for better navigation. These changes aim to enhance the overall UI consistency and user experience across the application.
- Changed instances of "Any user" to "Everyone" in the approval configuration documentation and UI components for consistency. - Updated related test cases to reflect the new terminology. - Enhanced the CanvasSettingsView component to accommodate the updated approval type label. These changes aim to improve clarity and consistency in the approval process terminology across the application.
|
👋 Commands for maintainers:
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Autofix Details
Bugbot Autofix prepared fixes for both issues found in the latest run.
- ✅ Fixed: New approver defaults to type that disables Add button
- Changed
addApproverto create aTYPE_USERentry (with emptyuserId) so the Everyone-approver guard no longer disables the Add button immediately while keeping the initial default as Everyone.
- Changed
- ✅ Fixed: Contradictory height classes on exit button
- Removed the dead
h-autoTailwind class from the exit button so only the intended height utility remains.
- Removed the dead
Or push these changes by commenting:
@cursor push c149192bac
Preview (c149192bac)
diff --git a/web_src/src/pages/workflowv2/CanvasSettingsView.tsx b/web_src/src/pages/workflowv2/CanvasSettingsView.tsx
--- a/web_src/src/pages/workflowv2/CanvasSettingsView.tsx
+++ b/web_src/src/pages/workflowv2/CanvasSettingsView.tsx
@@ -234,7 +234,7 @@
};
const addApprover = () => {
- setApprovers((current) => [...current, { type: "TYPE_ANYONE" }]);
+ setApprovers((current) => [...current, { type: "TYPE_USER", userId: "" }]);
};
const updateApproverType = (index: number, type: ChangeRequestApproverType) => {
diff --git a/web_src/src/ui/CanvasPage/index.tsx b/web_src/src/ui/CanvasPage/index.tsx
--- a/web_src/src/ui/CanvasPage/index.tsx
+++ b/web_src/src/ui/CanvasPage/index.tsx
@@ -1127,7 +1127,7 @@
type="button"
variant="link"
size="sm"
- className="h-auto min-h-0 shrink-0 gap-1 rounded-sm border border-amber-700 px-1.5 h-5 text-[13px] font-medium !text-amber-700 underline-offset-2 hover:!text-amber-700 hover:bg-white/10 hover:no-underline"
+ className="min-h-0 shrink-0 gap-1 rounded-sm border border-amber-700 px-1.5 h-5 text-[13px] font-medium !text-amber-700 underline-offset-2 hover:!text-amber-700 hover:bg-white/10 hover:no-underline"
onClick={() => props.onExitEditMode?.()}
disabled={props.exitEditModeDisabled}
aria-label="Exit edit mode"This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
… into ui-sanding
- Removed redundant height class from button in CanvasPage component to streamline styling. - This change enhances the overall visual consistency of the UI components.
- Changed default approver type from "TYPE_ANYONE" to "TYPE_USER" with an empty userId in the CanvasSettingsView component. - Updated related functions to ensure consistent handling of approver types throughout the component. These changes aim to enhance clarity and maintain consistency in the approval process within the application.
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
EtnDiaz
pushed a commit
to EtnDiaz/superplane
that referenced
this pull request
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.