fix: integration resource listing causing error 5xx#4012
Merged
forestileao merged 6 commits intomainfrom Apr 7, 2026
Merged
Conversation
Signed-off-by: Pedro F. Leao <pedroforestileao@gmail.com>
|
👋 Commands for maintainers:
|
pkg/grpc/actions/organizations/list_integration_resources_test.go
Outdated
Show resolved
Hide resolved
…rplane into fix/remaning-500-error
Co-authored-by: Pedro Leão <forestileao@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8c1927a. Configure here.
Collaborator
Author
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Change integration resource listing failures caused by integration/provider state into
FailedPreconditioninstead of a5xx.This prevents third-party integration issues from surfacing as internal server errors when calling:
GET /api/v1/organizations/{id}/integrations/{integration_id}/resourcesChanges
pkg/grpc/actions/organizations/list_integration_resources.goListResources(...)call fails, the API now:codes.FailedPrecondition5xxWhy
Resource listing depends on external integrations and provider-specific configuration.
If an integration is misconfigured, incomplete, disconnected, or a third-party provider fails, that is not an internal SuperPlane server error. Returning
FailedPreconditionmakes the failure semantics correct and avoids reporting provider/configuration problems as500-class errors.Example case:
botToken