Skip to content

Make linux compatible#4

Open
videgro wants to merge 2 commits intosupersjimmie:masterfrom
videgro:make_linux_compatible
Open

Make linux compatible#4
videgro wants to merge 2 commits intosupersjimmie:masterfrom
videgro:make_linux_compatible

Conversation

@videgro
Copy link

@videgro videgro commented Jan 28, 2018

Thanks for this great open source project to control the 'ITHO Eco Fan RFT' using the 'ESP8266'!

To let it compile in Arduino (1.8.5), running at Ubuntu (17.10), I made two small commits.
I hope you will integrate these into the 'master'.

Bugfix: Linux is case sensitive - Include Arduino.h instead of arduino.h
Bugfix: Without the typedef name, the keyword typedef is superfluous

Vincent de Groot added 2 commits January 28, 2018 16:03
While compiling with Arduino (1.8.5) at Ubuntu (17.10) I get the error below:

In file included from <home dir>/Arduino/libraries/Itho/CC1101.h:9:0,
                 from <home dir>/Arduino/libraries/Itho/IthoCC1101.h:9,
                 from <home dir>/IthoEcoFanRFT/Master/IthoEcoFanRFT/IthoEcoFanRFT.ino:28:
<home dir>/Arduino/libraries/Itho/CC1101Packet.h:10:21: fatal error: arduino.h: No such file or directory
 #include <arduino.h>
                     ^
compilation terminated.
exit status 1
Error compiling for board WeMos D1 R2 & mini.

Signed-off-by: Vincent de Groot <git@videgro.net>
While compiling with Arduino (1.8.5) at Ubuntu (17.10) I get the warnings below:

In file included from <home dir>/Arduino/libraries/Itho/IthoCC1101.h:10:0,
                 from <home dir>/IthoEcoFanRFT/Master/IthoEcoFanRFT/IthoEcoFanRFT.ino:28:
<home dir>/Arduino/libraries/Itho/IthoPacket.h:15:2: warning: 'typedef' was ignored in this declaration [enabled by default]
  };
  ^
In file included from /home/vincent/projects/itho-remote/IthoEcoFanRFT/Master/IthoEcoFanRFT/IthoEcoFanRFT.ino:28:0:
<home dir>/Arduino/libraries/Itho/IthoCC1101.h:68:1: warning: 'typedef' was ignored in this declaration [enabled by default]
 };
 ^
In file included from /home/vincent/Arduino/libraries/Itho/IthoCC1101.h:10:0,
                 from /home/vincent/Arduino/libraries/Itho/IthoCC1101.cpp:5:
<home dir>/Arduino/libraries/Itho/IthoPacket.h:15:2: warning: 'typedef' was ignored in this declaration [enabled by default]
  };
  ^
In file included from /home/vincent/Arduino/libraries/Itho/IthoCC1101.cpp:5:0:
<home dir>/Arduino/libraries/Itho/IthoCC1101.h:68:1: warning: 'typedef' was ignored in this declaration [enabled by default]
 };
 ^
Sketch uses 259268 bytes (24%) of program storage space. Maximum is 1044464 bytes.
Global variables use 33512 bytes (40%) of dynamic memory, leaving 48408 bytes for local variables. Maximum is 81920 bytes.

See also:
 https://stackoverflow.com/questions/6399898/is-the-typedef-name-optional-in-a-typedef-declaration

Signed-off-by: Vincent de Groot <git@videgro.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant