Skip to content

fix: failing auth-react tests [0.48] #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
porcellus merged 2 commits into from
Apr 29, 2025
Merged

fix: failing auth-react tests [0.48] #894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98bd802
fix: awaits `setupST` calls
namsnath Apr 21, 2025
fd7a385
fix: `after` hook page close failures
namsnath Apr 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion test/end-to-end/getRedirectionURL.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import { TEST_CLIENT_BASE_URL, SIGN_IN_UP_API } from "../constants";

describe("getRedirectionURL Tests", function () {
let browser;
let page;

before(async function () {
await backendHook("before");
Expand All @@ -46,6 +45,8 @@ describe("getRedirectionURL Tests", function () {

describe("Test that isNewRecipeUser is passed correctly", function () {
describe("Email Password Recipe", function () {
let page;

beforeEach(async function () {
page = await browser.newPage();
const coreUrl = await setupCoreApp();
Expand All @@ -72,6 +73,8 @@ describe("getRedirectionURL Tests", function () {
});

describe("Third party recipe", function () {
let page;

before(async function () {
const coreUrl = await setupCoreApp();
await setupST({ coreUrl });
Expand Down Expand Up @@ -105,6 +108,8 @@ describe("getRedirectionURL Tests", function () {
});

describe("Thirdpartyemailpassword recipe", function () {
let page;

before(async function () {
const coreUrl = await setupCoreApp();
await setupST({ coreUrl });
Expand Down Expand Up @@ -145,6 +150,7 @@ describe("getRedirectionURL Tests", function () {

describe("Passwordless recipe", function () {
const exampleEmail = "[email protected]";
let page;

before(async function () {
let _isPasswordlessSupported = await isPasswordlessSupported();
Expand Down Expand Up @@ -207,6 +213,7 @@ describe("getRedirectionURL Tests", function () {

describe("ThirdPartyPasswordless recipe", function () {
const exampleEmail = "[email protected]";
let page;

before(async function () {
let _isThirdPartyPasswordlessSupported = await isThirdPartyPasswordlessSupported();
Expand Down Expand Up @@ -283,6 +290,8 @@ describe("getRedirectionURL Tests", function () {

describe("No Redirection", function () {
describe("Email Password Recipe", function () {
let page;

before(async function () {
const coreUrl = await setupCoreApp();
await setupST({ coreUrl });
Expand Down Expand Up @@ -320,6 +329,7 @@ describe("getRedirectionURL Tests", function () {

describe("Passwordless recipe", function () {
const exampleEmail = "[email protected]";
let page;

before(async function () {
let _isPasswordlessSupported = await isPasswordlessSupported();
Expand Down Expand Up @@ -387,6 +397,7 @@ describe("getRedirectionURL Tests", function () {

describe("ThirdPartyPasswordless recipe: Magic Link", function () {
const exampleEmail = "[email protected]";
let page;

before(async function () {
let _isThirdPartyPasswordlessSupported = await isThirdPartyPasswordlessSupported();
Expand Down Expand Up @@ -453,6 +464,7 @@ describe("getRedirectionURL Tests", function () {
});

describe("ThirdParty Recipe", function () {
let page;
before(async function () {
const coreUrl = await setupCoreApp();
await setupST({ coreUrl });
Expand Down
16 changes: 8 additions & 8 deletions test/end-to-end/mfa.signin.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ describe("SuperTokens SignIn w/ MFA", function () {
it("sign in with email-otp (auto-setup)", async function () {
const email = await getTestEmail();

setupST({
await setupST({
...appConfig,
mfaInfo: {
requirements: ["otp-email"],
Expand All @@ -139,7 +139,7 @@ describe("SuperTokens SignIn w/ MFA", function () {
const email = await getTestEmail();
const phoneNumber = getTestPhoneNumber();

setupST({
await setupST({
...appConfig,
mfaInfo: {
requirements: [{ oneOf: ["otp-email", "otp-phone"] }],
Expand All @@ -163,7 +163,7 @@ describe("SuperTokens SignIn w/ MFA", function () {
});

it("set up otp-email and sign-in", async function () {
setupST({
await setupST({
...appConfig,
mfaInfo: {
requirements: [],
Expand All @@ -179,7 +179,7 @@ describe("SuperTokens SignIn w/ MFA", function () {

await logout(page);

setupST({
await setupST({
...appConfig,
mfaInfo: {
requirements: [{ oneOf: ["otp-email"] }],
Expand All @@ -203,15 +203,15 @@ describe("SuperTokens SignIn w/ MFA", function () {
});

it("set up totp and sign-in", async function () {
setupST({
await setupST({
...appConfig,
mfaInfo: {
requirements: [],
},
});
const email = await getTestEmail();

setupST({
await setupST({
...appConfig,
mfaInfo: {
requirements: [{ oneOf: ["otp-email", "totp"] }],
Expand Down Expand Up @@ -245,7 +245,7 @@ describe("SuperTokens SignIn w/ MFA", function () {

it("should show access denied if the only next option is an unknown factor id", async () => {
const email = await getTestEmail();
setupST({
await setupST({
...appConfig,
mfaInfo: {
requirements: ["unknown"],
Expand All @@ -258,7 +258,7 @@ describe("SuperTokens SignIn w/ MFA", function () {
});

it("should throw error if there are no valid next options", async () => {
setupST({
await setupST({
...appConfig,
mfaInfo: {
requirements: ["unknown"],
Expand Down
Loading