fix: separate helper method from test file #900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ No documentation updates required. |
Contributor
size-limit report 📦
|
porcellus
approved these changes
Jun 17, 2025
Collaborator
Merge activity
|
porcellus
pushed a commit
that referenced
this pull request
Aug 10, 2025
* feat: add mochawesome reporter
* update: makes test utils/server use applications
- Removes Start/Stop/Clean/Setup ST functions
- Adds a `/test/setup` endpoint to use `setupApp`
- Adds generic backend hook endpoints
* feat: setup mochawesome
- Adds screenshots to report
- Adds defaults to `.mocharc.yml`
* update: `emailverification` tests use core apps
- Each test runs independently
- Adds some additional steps to ensure tests are independent
- Cleans up test hooks
- Fixes verification failure test that relied on core being stopped
- Adds intercept to fail verification query
* update: `embed` tests use core apps
- Each test runs independently
- Adds some additional steps to ensure tests are independent
- Cleans up test hooks
* update: `generalerror` tests use core apps
* update: `getRedirectionURL` tests use core apps
* update: remove assertion on creating new apps
- Same appId can be re-used and will not create new apps
* update: `mfa.chooserscreen` tests use core apps
* feat: adds mocha envs to test config
* lint: format code
* update: `accountlinking` tests use core apps
- Each test runs independently
- Adds some additional steps to ensure tests are independent
- Cleans up test hooks
* update: `mfa.default_reqs` tests use core apps
- Each test runs independently
- Cleans up test hooks
* refactor: split app creation and ST setup utils
* update: `mfa.factorscreen.otp` tests use core apps
* refactor: split app creation and ST setup utils
* update: `mfa.factorscreen.totp` tests use core apps
* update: add missing backend hooks
* update: `mfa.firstFactors` tests use core apps
* update: `mfa.requirement_handling` tests use core apps
* update: `mfa.signin` tests use core apps
* update: `multitenancy.dynamic_login_methods` tests use core apps
* update: `multitenancy.tenant_interactions` tests use core apps
* update: `oauth2provider` tests use core apps
* update: `resetpasswordusingtoken` tests use core apps
* update: `signin-rrdv5/6` tests use core apps
* update: few `thirdparty` tests use core apps
* update: removes `visual` tests
* removes usages of old helper functions
* update: `userContext`/`userroles` tests use core apps
* fix: broken tests, update configs
* update: remove log
* fix: correct setup ST url
* test: only run few tests
* revert: test: only run few tests
* Fix package-lock issues
* Add some fixes for userContext and test server
* Port all webauthn tests to use updated test structure
* update: remove spec config in mocha
* Add init workflow for auth-react e2e tests
* Whitelist ci branch for tests
* Remove cdi version related code
* Add support for starting core in the tests
* Add compose for starting up core
* Explicitly pass APP_SERVER port in envs
* Use alternative approach to pass spec files to test action
* Parse the spec array into JSON to iterate through it
* Make some improvements in the workflow
* Add changes to run tests in a different workflow
* Update workflow to make it ready for merge
* Add workflow for unit tests
* Remove current branch from list of allowed branches in unit test
* Get rid of using random UUID for appId
* Rename Core test to Core Functionality
* Get rid of a TODO
* Get rid of using timeout in tests
* Get rid of setting appId from tests directly
* fix: failing auth-react tests [0.49] (#895)
* fix: awaits `setupST` calls
* fix: `after` hook page close failures
* feat: webauthn test flows (#883)
## Summary of change
This PR adds e2e test flows for webauthn and accountlinking
## Related issues
## Test Plan
All webauthn accountlinking tests should pass
## Documentation changes
(If relevant, please create a PR in our [docs repo](https://github.com/supertokens/docs), or create a checklist here highlighting the necessary changes)
## Checklist for important updates
- [ ] Changelog has been updated
- [ ] `frontendDriverInterfaceSupported.json` file has been updated (if needed)
- [ ] Changes to the version if needed
- In `package.json`
- In `package-lock.json`
- In `lib/ts/version.ts`
- [x] Had run `npm run build-pretty`
- [x] Had installed and ran the pre-commit hook
- [x] Issue this PR against the latest non released version branch.
- To know which one it is, run find the latest released tag (`git tag`) in the format `vX.Y.Z`, and then find the latest branch (`git branch --all`) whose `X.Y` is greater than the latest released tag.
- If no such branch exists, then create one from the latest released branch.
- [ ] If added a new recipe interface, then make sure that the implementation of it uses NON arrow functions only (like `someFunc: function () {..}`).
- [ ] If I added a new recipe, I also added the recipe entry point into the `size-limit` section of `package.json` with the size limit set to the current size rounded up.
- [ ] If I added a new recipe, I also added the recipe entry point into the `rollup.config.mjs`
- [ ] If I added a new login method, I modified the list in `lib/ts/types.ts`
- [ ] If I added a factor id, I modified the list in `lib/ts/recipe/multifactorauth/types.ts`
* fix: separate helper method from test file (#900)
## Summary of change
This PR removes a util method from the accountlinking test file and moves it to the helper file since it is used in 2 test files (accountlinking and webauthn) and the while running the webauthn tests, the accountlinking ones were also getting triggered because the helper was being imported from that file.
## Related issues
## Test Plan
All accountlinking and webauthn accountlinking tests should pass
## Documentation changes
(If relevant, please create a PR in our [docs repo](https://github.com/supertokens/docs), or create a checklist here highlighting the necessary changes)
## Checklist for important updates
- [ ] Changelog has been updated
- [ ] `frontendDriverInterfaceSupported.json` file has been updated (if needed)
- [ ] Changes to the version if needed
- In `package.json`
- In `package-lock.json`
- In `lib/ts/version.ts`
- [x] Had run `npm run build-pretty`
- [x] Had installed and ran the pre-commit hook
- [x] Issue this PR against the latest non released version branch.
- To know which one it is, run find the latest released tag (`git tag`) in the format `vX.Y.Z`, and then find the latest branch (`git branch --all`) whose `X.Y` is greater than the latest released tag.
- If no such branch exists, then create one from the latest released branch.
- [ ] If added a new recipe interface, then make sure that the implementation of it uses NON arrow functions only (like `someFunc: function () {..}`).
- [ ] If I added a new recipe, I also added the recipe entry point into the `size-limit` section of `package.json` with the size limit set to the current size rounded up.
- [ ] If I added a new recipe, I also added the recipe entry point into the `rollup.config.mjs`
- [ ] If I added a new login method, I modified the list in `lib/ts/types.ts`
- [ ] If I added a factor id, I modified the list in `lib/ts/recipe/multifactorauth/types.ts`
## Remaining TODOs for this PR
* feat: adds dev/release tag pipelines
- Sets up dev/release tag pipelines
- Adds script to populate common constants
- Updates workflows to run on PRs and dev-tags
* update: makes chromatic tests run on dev tag
- Ensures chromatic statuses are checked in the release checks
* update: web js interface variable to match action output
* doc: adds changelog
* update: GHA concurrency to cancel runs if new commit pushed
---------
Co-authored-by: Deepjyoti Barman <[email protected]>
Co-authored-by: Sattvik Chakravarthy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
This PR removes a util method from the accountlinking test file and moves it to the helper file since it is used in 2 test files (accountlinking and webauthn) and the while running the webauthn tests, the accountlinking ones were also getting triggered because the helper was being imported from that file.
Related issues
Test Plan
All accountlinking and webauthn accountlinking tests should pass
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
frontendDriverInterfaceSupported.jsonfile has been updated (if needed)package.jsonpackage-lock.jsonlib/ts/version.tsnpm run build-prettygit tag) in the formatvX.Y.Z, and then find the latest branch (git branch --all) whoseX.Yis greater than the latest released tag.someFunc: function () {..}).size-limitsection ofpackage.jsonwith the size limit set to the current size rounded up.rollup.config.mjslib/ts/types.tslib/ts/recipe/multifactorauth/types.tsRemaining TODOs for this PR