ci: add extra log to debug failure on CI #912
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| ); | ||
| }); | ||
| page.on("requestfinished", async (req) => { | ||
| if (req.method() === "OPTION") { |
There was a problem hiding this comment.
The HTTP method should be OPTIONS (with an 'S' at the end) rather than OPTION. This typo will prevent the condition from matching actual OPTIONS requests, causing them to be processed when they should be skipped.
Suggested change
| if (req.method() === "OPTION") { | |
| if (req.method() === "OPTIONS") { |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Comment on lines
+120
to
+128
| const resp = await req.response(); | ||
| let respText; | ||
| try { | ||
| respText = req.url().startsWith(TEST_APPLICATION_SERVER_BASE_URL) | ||
| ? await resp.text() | ||
| : "response omitted"; | ||
| } catch (e) { | ||
| respText = "response loading failed " + e.message; | ||
| } |
There was a problem hiding this comment.
When handling failed requests, resp could be null or undefined, which would cause errors when calling resp.status() or resp.text(). Consider adding a null check before accessing response properties:
const resp = await req.response();
let respText;
if (!resp) {
respText = 'No response available';
} else {
try {
respText = req.url().startsWith(TEST_APPLICATION_SERVER_BASE_URL)
? await resp.text()
: "response omitted";
} catch (e) {
respText = "response loading failed " + e.message;
}
}This will prevent potential runtime errors when processing failed requests.
Suggested change
| const resp = await req.response(); | |
| let respText; | |
| try { | |
| respText = req.url().startsWith(TEST_APPLICATION_SERVER_BASE_URL) | |
| ? await resp.text() | |
| : "response omitted"; | |
| } catch (e) { | |
| respText = "response loading failed " + e.message; | |
| } | |
| const resp = await req.response(); | |
| let respText; | |
| if (!resp) { | |
| respText = 'No response available'; | |
| } else { | |
| try { | |
| respText = req.url().startsWith(TEST_APPLICATION_SERVER_BASE_URL) | |
| ? await resp.text() | |
| : "response omitted"; | |
| } catch (e) { | |
| respText = "response loading failed " + e.message; | |
| } | |
| } |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
(A few sentences about this PR)
Related issues
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
frontendDriverInterfaceSupported.jsonfile has been updated (if needed)package.jsonpackage-lock.jsonlib/ts/version.tsnpm run build-prettygit tag) in the formatvX.Y.Z, and then find the latest branch (git branch --all) whoseX.Yis greater than the latest released tag.someFunc: function () {..}).size-limitsection ofpackage.jsonwith the size limit set to the current size rounded up.rollup.config.mjslib/ts/types.tslib/ts/recipe/multifactorauth/types.tsRemaining TODOs for this PR