-
Notifications
You must be signed in to change notification settings - Fork 95
update: use new get-versions-from-repo action #913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e0c1424
update: use new get-versions-from-repo action in auth-react
namsnath 3141ae0
fix: npm install issues with auth-react setup action
namsnath fc4ba6a
fix: retrieve workspace manually
namsnath 4ce28f1
fix: directory
namsnath 536e269
Merge branch '0.50' into update/gha/use-new-versions-action
porcellus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,13 +21,22 @@ jobs: | |
| runs-on: ubuntu-latest | ||
| outputs: | ||
| fdiVersions: ${{ steps.versions.outputs.fdiVersions }} | ||
|
|
||
| nodeFdiVersionMap: ${{ steps.node-versions.outputs.fdiVersions }} | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: supertokens/get-supported-versions-action@main | ||
| id: versions | ||
| with: | ||
| has-fdi: true | ||
|
|
||
| - uses: supertokens/actions/get-versions-from-repo@main | ||
| id: node-versions | ||
| with: | ||
| repo: supertokens-node | ||
| github-token: ${{ secrets.GITHUB_TOKEN }} | ||
| fdi-versions: ${{ steps.versions.outputs.fdiVersions }} | ||
|
|
||
| setup-auth-react: | ||
| runs-on: ubuntu-latest | ||
| needs: define-versions | ||
|
|
@@ -45,21 +54,30 @@ jobs: | |
| AUTH_REACT__PORT: ${{ steps.envs.outputs.AUTH_REACT__PORT }} | ||
| specs: ${{ steps.envs.outputs.specs }} | ||
| fdiVersions: ${{ needs.define-versions.outputs.fdiVersions }} | ||
| nodeFdiVersionMap: ${{ needs.define-versions.outputs.nodeFdiVersionMap }} | ||
|
|
||
| steps: | ||
| - uses: supertokens/get-versions-action@main | ||
| id: versions | ||
| - id: repo-versions | ||
| run: | | ||
| nodeVersion=$( echo '${{ needs.define-versions.outputs.nodeFdiVersionMap }}' | jq -r '.["${{ matrix.fdi-version }}"]' ) | ||
| echo "nodeVersion=${nodeVersion}" >> $GITHUB_OUTPUT | ||
|
|
||
| # We will use this in the test run to get the core version | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| driver-name: node | ||
| fdi-version: ${{ matrix.fdi-version }} | ||
| env: | ||
| SUPERTOKENS_API_KEY: ${{ secrets.SUPERTOKENS_API_KEY }} | ||
| repository: supertokens/supertokens-node | ||
| ref: ${{ steps.repo-versions.outputs.nodeVersion }} | ||
| path: supertokens-node | ||
|
|
||
| # Makes npm use HTTP instead of SSH for installs | ||
| - name: Reconfigure git to use HTTP authentication | ||
| run: git config --global url."https://github.com/".insteadOf ssh://[email protected]/ | ||
|
|
||
| - uses: supertokens/auth-react-testing-action/setup@main | ||
| id: envs | ||
| with: | ||
| auth-react-version: ${{ github.sha }} | ||
| node-sdk-version: ${{ steps.versions.outputs.nodeTag }} | ||
| node-sdk-version: ${{ steps.repo-versions.outputs.nodeVersion }} | ||
| fdi-version: ${{ matrix.fdi-version }} | ||
| use-common-app-and-test-server: "true" | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a syntax error in this line. The pipe (
|) after the closing parenthesis is causing thesedcommand to run separately from the variable assignment, which isn't what you want. The correct syntax would be:lastNodeCdiVersion=$(echo '${{ steps.node-cdi-versions.outputs.cdiVersions }}' | jq -r '.[-1]')If you need to escape quotes in the variable, you could include the
sedcommand inside the command substitution:lastNodeCdiVersion=$(echo '${{ steps.node-cdi-versions.outputs.cdiVersions }}' | jq -r '.[-1]' | sed -e 's/"/\\"/g')Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.