Skip to content

fix(performance): reuse http client #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amirsalarsafaei wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(performance): reuse http client #438

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions supertokens/querier.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ var (
querierInterceptor func(*http.Request, UserContext) (*http.Request, error)
querierGlobalCacheTag uint64
querierDisableCache bool
querierHTTPClient *http.Client
)

func SetQuerierApiVersionForTests(version string) {
Expand Down Expand Up @@ -113,8 +114,7 @@ func (q *Querier) GetQuerierAPIVersion(userContextIn ...UserContext) (string, er
req.Header = headers
}

client := &http.Client{}
resp, err := client.Do(req)
resp, err := querierHTTPClient.Do(req)
return resp, nil, err
}, len(QuerierHosts), nil)

Expand Down Expand Up @@ -162,6 +162,8 @@ func initQuerier(hosts []QuerierHost, APIKey string, interceptor func(*http.Requ
querierInterceptor = interceptor
querierGlobalCacheTag = GetCurrTimeInMS()
querierDisableCache = disableCache

querierHTTPClient = &http.Client{}
}
}

Expand Down Expand Up @@ -205,8 +207,7 @@ func (q *Querier) SendPostRequest(path string, data map[string]interface{}, user
}
}

client := &http.Client{}
resp, err := client.Do(req)
resp, err := querierHTTPClient.Do(req)
return resp, nil, err
}, len(QuerierHosts), nil)
return resp, err
Expand Down Expand Up @@ -256,8 +257,7 @@ func (q *Querier) SendDeleteRequest(path string, data map[string]interface{}, pa
}
}

client := &http.Client{}
resp, err := client.Do(req)
resp, err := querierHTTPClient.Do(req)
return resp, nil, err
}, len(QuerierHosts), nil)
return resp, err
Expand Down Expand Up @@ -360,8 +360,7 @@ func (q *Querier) SendGetRequest(path string, params map[string]string, userCont
}
}

client := &http.Client{}
response, err := client.Do(req)
response, err := querierHTTPClient.Do(req)
if err != nil {
return nil, nil, err
}
Expand Down Expand Up @@ -435,8 +434,7 @@ func (q *Querier) SendGetRequestWithResponseHeaders(path string, params map[stri
}
}

client := &http.Client{}
resp, err := client.Do(req)
resp, err := querierHTTPClient.Do(req)
return resp, nil, err
}, len(QuerierHosts), nil)
}
Expand Down Expand Up @@ -478,8 +476,7 @@ func (q *Querier) SendPutRequest(path string, data map[string]interface{}, userC
}
}

client := &http.Client{}
resp, err := client.Do(req)
resp, err := querierHTTPClient.Do(req)
return resp, nil, err
}, len(QuerierHosts), nil)
return resp, err
Expand Down