Skip to content

Conversation

@sattvikc
Copy link
Collaborator

Summary of change

(A few sentences about this PR)

Related issues

  • Link to issue1 here
  • Link to issue1 here

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your
changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here
highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • pluginInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In build.gradle
  • Had installed and ran the pre-commit hook
  • If there are new dependencies that have been added in build.gradle, please make sure to add them
    in implementationDependencies.json.
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the
      latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • When adding new recipes, ensure that its performance is being measured in the OneMillionUsersTest

Remaining TODOs for this PR

  • Item1
  • Item2

&& apt-get purge -y --auto-remove wget
COPY --from=tmp --chown=supertokens /usr/lib/supertokens /usr/lib/supertokens
COPY --from=tmp --chown=supertokens /usr/bin/supertokens /usr/bin/supertokens
COPY ./supertokens-postgresql-plugin/.github/helpers/docker/docker-entrypoint.sh /usr/local/bin/
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The path to docker-entrypoint.sh appears to be incorrect. The Dockerfile is trying to copy from ./supertokens-postgresql-plugin/.github/helpers/docker/docker-entrypoint.sh, but based on the PR context, the script is likely in the same directory as the Dockerfile (.github/helpers/docker/).

Consider changing the path to:

COPY ./docker-entrypoint.sh /usr/local/bin/

This will ensure the Docker build can locate the entrypoint script correctly.

Suggested change
COPY ./supertokens-postgresql-plugin/.github/helpers/docker/docker-entrypoint.sh /usr/local/bin/
COPY ./docker-entrypoint.sh /usr/local/bin/

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

echo "Unsupported architecture: $ARCH" && exit 1; \
fi
RUN unzip jre.zip
RUN mv jre-15.0.1 jre || mv jre-15.0.1-linux-aarch/jre-15.0.1 jre
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ARM JRE extraction path appears inconsistent with the downloaded file name. The script downloads jre-15.0.1-linux-arm.zip but attempts to extract from jre-15.0.1-linux-aarch/jre-15.0.1. Consider updating the extraction path to match the expected directory structure of the downloaded ARM zip file, likely jre-15.0.1-linux-arm/jre-15.0.1 or simply jre-15.0.1-linux-arm.

Suggested change
RUN mv jre-15.0.1 jre || mv jre-15.0.1-linux-aarch/jre-15.0.1 jre
RUN mv jre-15.0.1 jre || mv jre-15.0.1-linux-arm/jre-15.0.1 jre

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

Comment on lines +41 to +42
COPY --from=tmp --chown=supertokens /usr/lib/supertokens /usr/lib/supertokens
COPY --from=tmp --chown=supertokens /usr/bin/supertokens /usr/bin/supertokens
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The COPY commands reference paths in the tmp stage (/usr/lib/supertokens and /usr/bin/supertokens) that don't appear to be created in the Dockerfile. The build process in the tmp stage places files in the /build directory, but there are no commands to move these files to the locations referenced by the COPY instructions.

Either:

  1. Add commands in the tmp stage to move the built files to these expected locations:

    RUN mkdir -p /usr/lib/supertokens /usr/bin/supertokens
    RUN cp -r /build/* /usr/lib/supertokens/
    # And appropriate command to create the binary in /usr/bin/supertokens
  2. Or modify the COPY commands to reference the actual locations where files exist in the tmp stage:

    COPY --from=tmp --chown=supertokens /build /usr/lib/supertokens
    # And appropriate path for the binary
Suggested change
COPY --from=tmp --chown=supertokens /usr/lib/supertokens /usr/lib/supertokens
COPY --from=tmp --chown=supertokens /usr/bin/supertokens /usr/bin/supertokens
COPY --from=tmp --chown=supertokens /build /usr/lib/supertokens
COPY --from=tmp --chown=supertokens /build/supertokens /usr/bin/supertokens

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

@sattvikc sattvikc merged commit e8ca640 into 5.0 Aug 12, 2025
2 of 4 checks passed
@sattvikc sattvikc deleted the for-backport-release-7-0 branch August 12, 2025 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants