-
Notifications
You must be signed in to change notification settings - Fork 16
fix: for backport 7.0. #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| && apt-get purge -y --auto-remove wget | ||
| COPY --from=tmp --chown=supertokens /usr/lib/supertokens /usr/lib/supertokens | ||
| COPY --from=tmp --chown=supertokens /usr/bin/supertokens /usr/bin/supertokens | ||
| COPY ./supertokens-postgresql-plugin/.github/helpers/docker/docker-entrypoint.sh /usr/local/bin/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The path to docker-entrypoint.sh appears to be incorrect. The Dockerfile is trying to copy from ./supertokens-postgresql-plugin/.github/helpers/docker/docker-entrypoint.sh, but based on the PR context, the script is likely in the same directory as the Dockerfile (.github/helpers/docker/).
Consider changing the path to:
COPY ./docker-entrypoint.sh /usr/local/bin/
This will ensure the Docker build can locate the entrypoint script correctly.
| COPY ./supertokens-postgresql-plugin/.github/helpers/docker/docker-entrypoint.sh /usr/local/bin/ | |
| COPY ./docker-entrypoint.sh /usr/local/bin/ |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
| echo "Unsupported architecture: $ARCH" && exit 1; \ | ||
| fi | ||
| RUN unzip jre.zip | ||
| RUN mv jre-15.0.1 jre || mv jre-15.0.1-linux-aarch/jre-15.0.1 jre |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ARM JRE extraction path appears inconsistent with the downloaded file name. The script downloads jre-15.0.1-linux-arm.zip but attempts to extract from jre-15.0.1-linux-aarch/jre-15.0.1. Consider updating the extraction path to match the expected directory structure of the downloaded ARM zip file, likely jre-15.0.1-linux-arm/jre-15.0.1 or simply jre-15.0.1-linux-arm.
| RUN mv jre-15.0.1 jre || mv jre-15.0.1-linux-aarch/jre-15.0.1 jre | |
| RUN mv jre-15.0.1 jre || mv jre-15.0.1-linux-arm/jre-15.0.1 jre |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
| COPY --from=tmp --chown=supertokens /usr/lib/supertokens /usr/lib/supertokens | ||
| COPY --from=tmp --chown=supertokens /usr/bin/supertokens /usr/bin/supertokens |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The COPY commands reference paths in the tmp stage (/usr/lib/supertokens and /usr/bin/supertokens) that don't appear to be created in the Dockerfile. The build process in the tmp stage places files in the /build directory, but there are no commands to move these files to the locations referenced by the COPY instructions.
Either:
-
Add commands in the
tmpstage to move the built files to these expected locations:RUN mkdir -p /usr/lib/supertokens /usr/bin/supertokens RUN cp -r /build/* /usr/lib/supertokens/ # And appropriate command to create the binary in /usr/bin/supertokens
-
Or modify the
COPYcommands to reference the actual locations where files exist in thetmpstage:COPY --from=tmp --chown=supertokens /build /usr/lib/supertokens # And appropriate path for the binary
| COPY --from=tmp --chown=supertokens /usr/lib/supertokens /usr/lib/supertokens | |
| COPY --from=tmp --chown=supertokens /usr/bin/supertokens /usr/bin/supertokens | |
| COPY --from=tmp --chown=supertokens /build /usr/lib/supertokens | |
| COPY --from=tmp --chown=supertokens /build/supertokens /usr/bin/supertokens | |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Summary of change
(A few sentences about this PR)
Related issues
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your
changes work. Bonus points for screenshots and videos!)
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here
highlighting the necessary changes)
Checklist for important updates
pluginInterfaceSupported.jsonfile has been updated (if needed)build.gradlebuild.gradle, please make sure to add themin
implementationDependencies.json.git tag) in the formatvX.Y.Z, and then find thelatest branch (
git branch --all) whoseX.Yis greater than the latest released tag.OneMillionUsersTestRemaining TODOs for this PR