Fix scan accept/reject gating and pose bookkeeping; expose plane rejection stats#60
Open
tejasps28 wants to merge 1 commit intosuperxslam:dev/humanoid_mid360from
Open
Fix scan accept/reject gating and pose bookkeeping; expose plane rejection stats#60tejasps28 wants to merge 1 commit intosuperxslam:dev/humanoid_mid360from
tejasps28 wants to merge 1 commit intosuperxslam:dev/humanoid_mid360from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a logic bug in LidarSlam.cpp that effectively disabled scan rejection, corrects
last_T_w_lidar bookkeeping so motion deltas are computed against the last accepted pose, and makes
plane rejection diagnostics visible in /super_odometry_stats. It also wires the global
use_imu_roll_pitch parameter so YAML settings are actually respected.
Changes
invalid dt.
Why
Validation
increments remained stable, while plane_* diagnostics are now non-zero and informative.
rarely trigger).