Activity adoption changes#752
Merged
suren-atoyan merged 1 commit intosuren-atoyan:masterfrom Oct 12, 2025
Merged
Conversation
Owner
|
@EugeneChoi4 thanks for the PR 🙌 I'll check and merge this next week |
suren-atoyan
approved these changes
Oct 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Activity is a new React component that has recently been released on @canary and allows users to show/hide UI while preserving internal state. The current
Editorcomponent (and potentially others) are not compatible withActivityas certain refs are not disposed when effects are cleaned up.This PR demonstrates a potential fix for the
Editorcomponent. Note that I have not dug super deep into the code so this may present side effects that I am not aware of, the changes to the playground are only for testing as well.Mentioned in issue #753