Merge 7.4 and resolve conflicts #254

NullIsOne · 2023-07-24T09:14:15Z

Что сделано?

Слита ветка 7.4 в develop
Разрешены конфликты с учетом изменений GeneratorsProvider на SectionsProvider
Добавлен вызов accessibility плагина на экранах, что появились позже
Поправлены тесты примера paginatable плагина
...

Зачем это сделано?

Чтобы объединить изменения из готовящейся 8.0 и зарелиженой. 7.4

На что обратить внимание?

На CI теперь более четко отслеживается результат Unit/UI тестов. Держим 100% успешных тестов
...

Как протестировать?

Успех в buildCheck
Отсутствие падений в примере
П.C. Полезно будет также прогнать тесты на Xcode 15, чтобы зафиксировать работу "performAccessibilityAudit"

[SPT-1480] RDDM Accessibility optimizations

# Conflicts: # Brewfile.lock.json # Example/ReactiveDataDisplayManager/Collection/CollectionCompositionalViewController/CollectionCompositionalViewController.swift # Example/ReactiveDataDisplayManager/Collection/CollectionViewController/CollectionViewController.swift # Example/ReactiveDataDisplayManager/Collection/MainCollectionViewController/MainCollectionViewController.swift # Example/ReactiveDataDisplayManager/Table/MainTableViewController/MainTableViewController.swift # Example/ReactiveDataDisplayManager/Table/SectionTitleTableViewController/SectionTitleTableViewController.swift # Example/ReactiveDataDisplayManager/Table/Views/Cells/ExpandableTableCell/ExpandableTableCell.swift # Example/ReactiveDataDisplayManager/Table/Views/Cells/TitleTableViewCell/TitleTableViewCell.swift # Example/project.yml # Example/targets/template.yml # Gemfile.lock # ReactiveDataDisplayManager.podspec # ReactiveDataDisplayManagerTests/BaseStackDataDisplatManagerTests.swift # ReactiveDataDisplayManagerTests/Mocks/AutoMockable.generated.swift # Source/Collection/Deprecated/BaseCollectionDataDisplayManager.swift # Source/Collection/Generators/EmptyCollectionFooterGenarator.swift # Source/Collection/Generators/EmptyCollectionHeaderGenerator.swift # Source/Collection/Manager/BaseCollectionManager.swift # Source/Collection/Plugins/PluginAction/CollectionPaginatablePlugin.swift # Source/Collection/Protocols/CollectionFoldableItem.swift # Source/Protocols/GeneratorsProvider.swift # Source/Protocols/Protocols.swift # Source/Table/DataSource/TableGeneratorsProvider.swift # Source/Table/Deprecated/BaseTableDataDisplayManager.swift # Source/Table/Generators/EmptyHeaderGenerator.swift # Source/Table/Manager/BaseTableManager.swift # Source/Table/Manager/GravityTableManager.swift # Source/Table/Manager/ManualTableManager.swift # Source/Table/Plugins/PluginAction/TableDisplayablePlugin.swift # Source/Table/Plugins/PluginAction/TableLastCellIsVisiblePlugin.swift # Source/Table/Plugins/PluginAction/TablePaginatablePlugin.swift # hooks/post-checkout # project.yml

github-actions · 2023-07-24T09:15:27Z

	Warnings
⚠️	The .yml file has been modified. Keep `changelog.md` up to date.
⚠️	Oops! We have found some issues. It's better to fix them to keep code clean

SwiftLint found issues

Severity	File	Reason
Warning	AccessibilityItem+Invalidation.swift:90	Line should be 145 characters or less: currently 158 characters (`line_length`)

Generated by 🚫 Danger Swift against 7fd0ec7

codecov-commenter · 2023-07-24T11:43:01Z

Codecov Report

Patch coverage: 60.34% and project coverage change: +1.28% 🎉

Comparison is base (aa95890) 71.37% compared to head (7fd0ec7) 72.66%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #254      +/-   ##
===========================================
+ Coverage    71.37%   72.66%   +1.28%     
===========================================
  Files          146      161      +15     
  Lines         4457     4905     +448     
  Branches      2000     2224     +224     
===========================================
+ Hits          3181     3564     +383     
- Misses        1176     1221      +45     
- Partials       100      120      +20

Flag	Coverage Δ
uitests	`64.05% <61.04%> (+2.73%)`	⬆️
unittests	`34.02% <7.54%> (-3.22%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
...on/Generators/EmptyCollectionFooterGenarator.swift	`66.66% <0.00%> (ø)`
.../Collection/Protocols/CollectionFoldableItem.swift	`0.00% <0.00%> (ø)`
...cessibility/Container/AccessibilityContainer.swift	`0.00% <0.00%> (ø)`
...ssibility/Container/AccessibilityItemWrapper.swift	`0.00% <0.00%> (ø)`
...ators/Accessibility/Item/AccessibilityAction.swift	`0.00% <0.00%> (ø)`
...lity/Modifier/AccessibilityContainerModifier.swift	`0.00% <0.00%> (ø)`
...ce/Protocols/Plugins/Generators/FoldableItem.swift	`0.00% <0.00%> (ø)`
...Table/Generators/EmptyGravityFooterGenerator.swift	`0.00% <0.00%> (ø)`
...e/Table/Generators/EmptyTableFooterGenerator.swift	`72.72% <0.00%> (+72.72%)`	⬆️
Source/Table/Manager/GravityTableManager.swift	`74.11% <0.00%> (+1.28%)`	⬆️
... and 29 more

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

NullIsOne · 2023-07-25T09:54:00Z

Итого возьмем на заметку что мердж прошел успешно за исключением a11y теста стеков и компонентов.

На CI успех потому что пока проверяем на Xcode 14.

Разработка и отладка стековой ячейки в процессе - #253
Пример с компонентами будет упразднен и полностью переедет в чат.

Sergey Korshunov and others added 30 commits July 19, 2023 15:50

make init

d55ae3c

added accessibility parser

a6a97cf

added accessibility plugin

3531e71

added accessibility strategies

8414389

added accessibility cell

2db2ba4

renamed protocols

ba6d2b7

fixed collection plugin

409472f

added table accessibility plugin

fb3db9d

added traits provider for base protocols

daa29db

fixed swiftlint

5bf16b7

added some example

63beef1

added comments

81beafa

update hooks

13e233f

accessibility improvements

e7fcce1

fixed modifier methods

69b1c92

made default accessibility modifier public

107aaad

fixed modifier

ca8ff8b

fixed tests

d9fc358

implemented accessibility for collection views

d28f1a1

renamed default modifier, added custom actions support

102d52c

removed separator

cde4c3f

expandable table cell accessibility

561931a

update structure

2e4b661

added accessibility invalidation

728d61b

added accessibility to expandable table cell

c513436

added public modifiers

192ff53

added accessibility invalidator

ea858b8

refactor, item fixes

86d2c90

added comments

ae77ec5

fixed tests & run sourcery

e5b7b98

NullIsOne added 14 commits July 19, 2023 16:03

add shortcuts to improve modification out of rddm

d06e8ad

make container not acessible element if accessibility is ignored

caf458b

fix rebase conflicts

dfbaa61

update AccessibilityItemInvalidator protocol and implementations

bb209f4

add filtration for a11y string values

8a2cdef

add AccessibilityAction and Strategy to apply it in Modifier

795c1bd

fix linter issues

2bdde92

make invalidator configurable

58f59fa

fix isAccessibilityIgnored

d25de15

update documentation

b5bb525

fix init for ItemWrapper

72f69d7

Merge pull request #239 from surfstudio/feature/SPT-1480-optimizations

5462585

[SPT-1480] RDDM Accessibility optimizations

update version to 7.4

a74ff3a

NullIsOne added the 8.0 label Jul 24, 2023

NullIsOne self-assigned this Jul 24, 2023

NullIsOne added 4 commits July 24, 2023 13:23

fix linter issues

f0713b4

fix short init for TableSection

72f9b3f

fix titles in UI tests

87af96f

update font to prefered font

cfdfe2a

NullIsOne added 4 commits July 24, 2023 16:38

add missed accessibility plugin for new example controllers

c6f5276

fix paginatable plugin UI tests

9cab6d6

fix a11y issues

88b3cc5

add height calculation for titletableviewcell from example

7fd0ec7

NullIsOne mentioned this pull request Jul 21, 2023

[SPT-1555] Universal StackView #253

Open

NullIsOne merged commit cbf811a into develop Jul 25, 2023

NullIsOne deleted the feature/resolve_7.4_conflicts branch July 25, 2023 10:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Merge 7.4 and resolve conflicts #254

Merge 7.4 and resolve conflicts #254

Uh oh!

NullIsOne commented Jul 24, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Jul 24, 2023 •

edited

Loading

Uh oh!

codecov-commenter commented Jul 24, 2023 •

edited

Loading

Uh oh!

NullIsOne commented Jul 25, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Merge 7.4 and resolve conflicts #254

Merge 7.4 and resolve conflicts #254

Uh oh!

Conversation

NullIsOne commented Jul 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Что сделано?

Зачем это сделано?

На что обратить внимание?

Как протестировать?

Uh oh!

github-actions bot commented Jul 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SwiftLint found issues

Uh oh!

codecov-commenter commented Jul 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

NullIsOne commented Jul 25, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

NullIsOne commented Jul 24, 2023 •

edited

Loading

github-actions bot commented Jul 24, 2023 •

edited

Loading

codecov-commenter commented Jul 24, 2023 •

edited

Loading