Stop when we reach end_lr even if the loss did not diverge#5
Open
Vermeille wants to merge 1 commit intosurmenok:masterfrom
Vermeille:patch-1
Open
Stop when we reach end_lr even if the loss did not diverge#5Vermeille wants to merge 1 commit intosurmenok:masterfrom Vermeille:patch-1
Vermeille wants to merge 1 commit intosurmenok:masterfrom
Vermeille:patch-1
Conversation
Stop when we reach end_lr even if the loss did not diverge. In some cases, the loss will not increase and diverge, so make sure we stop at end_lr (as the user asked anyway)
Owner
|
Thanks for the pull request! Why does this situation happen? The finder uses start_lr and end_lr to calculate the rate of lr increase: So, after going through all epochs, we should end up roughly with end_lr. If it doesn't happen, it might be better to fix calculation of lr_mult. |
Author
|
HA! You're 100% correct. I was a bit too negligent with that one. I actually saw a very similar piece of code on another repo (like, almost line-by-line similar), and that one did not call So, when I saw yours, I immediately thought you'd have the same issue, but you actually don't :) Sorry for the inconvenience! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop when we reach end_lr even if the loss did not diverge.
In some cases, the loss will not increase and diverge, so make sure we stop at end_lr (as the user asked anyway)