Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,12 @@ jobs:
fail-fast: false
matrix:
include:
# v3.0.0-beta.2 with Go 1.25.0
- surrealdb-version: 'v3.0.0-beta.2'
# v3.0.1 with Go 1.25.0
- surrealdb-version: 'v3.0.1'
go-version: '1.25.0'
connection-type: 'ws'
surrealdb-url: 'ws://localhost:8000/rpc'
- surrealdb-version: 'v3.0.0-beta.2'
- surrealdb-version: 'v3.0.1'
go-version: '1.25.0'
connection-type: 'http'
surrealdb-url: 'http://localhost:8000'
Expand Down
8 changes: 8 additions & 0 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,14 @@ linters:
goconst:
min-len: 2
min-occurrences: 3
gosec:
excludes:
# Password fields are fundamental to a DB SDK
- G117
# HTTP requests use URLs from user configuration, not tainted input
- G704
# Log messages contain DB metadata (namespace/table names), not user input
- G706
gocritic:
disabled-checks:
- dupImport
Expand Down
2 changes: 1 addition & 1 deletion contrib/surrealql/define.go
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ func (q *DefineTableQuery) Build() (query string, params map[string]any) {
if len(q.permissions) > 0 {
builder.WriteString(" PERMISSIONS")
for _, p := range q.permissions {
builder.WriteString(fmt.Sprintf(" %s %s", strings.ToUpper(p.perm), p.value))
fmt.Fprintf(&builder, " %s %s", strings.ToUpper(p.perm), p.value)
}
}

Expand Down
2 changes: 1 addition & 1 deletion contrib/surrealql/show.go
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ func (q *ShowChangesForTableQuery) Build() (sql string, vars map[string]any) {
}

if q.limit > 0 {
builder.WriteString(fmt.Sprintf(" LIMIT %d", q.limit))
fmt.Fprintf(&builder, " LIMIT %d", q.limit)
}

return builder.String(), c.vars
Expand Down
10 changes: 10 additions & 0 deletions contrib/surrealrestore/restore_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,16 @@ func TestRestorerFull(t *testing.T) {
t.Fatalf("Failed to init source db: %v", err)
}

// Check if this is SurrealDB 3.x - skip due to changefeed behavior changes
// This may be revisited once 3.0 GA is out and changefeed behavior is stable
v, vErr := testenv.GetVersion(ctx, sourceDB)
if vErr != nil {
t.Fatalf("Failed to get SurrealDB version: %v", vErr)
}
if v.IsV3OrLater() {
t.Skip("Skipping incremental dump/restore test on SurrealDB 3.x - changefeed behavior has changed significantly")
}

// Insert test data
type TestRecord struct {
ID string `json:"id,omitempty"`
Expand Down
Loading
Loading