fix(terminal): fix race condition preventing onData listeners from receiving data when set immediately after construction

[MBanucu]

Closes #35

Summary

• Updates src/terminal.ts with core logic improvements
• Updates src/terminal.integration.test.ts with enhanced integration tests

Summary by CodeRabbit

• Bug Fixes

  • Resolved a timing issue so event listeners (onData/onExit) reliably receive events when attached immediately after Terminal creation.

• Tests

  • Added integration tests verifying listeners receive terminal data and exit events when set immediately, including conditional sync coverage and cross-platform timeouts.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

The PTY read loop startup in Terminal was deferred to a microtask (queueMicrotask) so constructors complete before reading begins. Two integration tests were added to validate immediate onData wiring and a conditional sync test with cross-platform timeouts.

Changes

Cohort / File(s)	Summary
Read Loop Deferral src/terminal.ts	Start PTY read loop via queueMicrotask instead of starting synchronously in the constructor; comment added explaining rationale.
Integration Tests src/terminal.integration.test.ts	Added two tests: one verifying onData receives data when attached immediately after construction, and a conditional "sync tests" verifying onExit/onData behavior with timeouts and kill flow.

Sequence Diagram(s)

(omitted — changes are limited to deferring a read loop start and added tests; no multi-component sequential flow requiring visualization)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• fix: enable bun compile support and fix Windows path handling #25 — Modifies src/terminal.ts constructor behavior; related by changes to read-loop/startup timing and constructor internals.
• fix: use TextDecoder streaming mode to handle UTF-8 across chunk boundaries #33 — Adjusts PTY read loop chunk decoding; related to PTY read-loop implementation and data handling.

Poem

I nibble on a microtask light,
Listeners settle snug and tight.
Data waits till setup's done,
No race, no sprint — just gentle fun. 🐇✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main fix: addressing a race condition where onData listeners couldn't receive data when attached immediately after Terminal construction.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@src/terminal.integration.test.ts`:
- Around line 503-533: The test creates a Terminal instance but never registers
it with the shared terminals array used by the global afterEach cleanup; after
constructing the terminal (const terminal = new Terminal(cmd, args)) add
terminals.push(terminal) so the test's Terminal is cleaned up on exceptions via
the existing afterEach logic (referencing the terminals array and the Terminal
instance variable).