Panel layout manager #598
Draft
Panel layout manager #598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+53
to
+56
| header.innerHTML = ` | ||
| <div class="sa-panel-layout__item-title">${title}</div> | ||
| <div class="sa-panel-layout__item-coords">${panel.x},${panel.y} | ${panel.width}×${panel.height}</div> | ||
| `; |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 1 month ago
How to fix:
The core issue is the unescaped insertion of possibly-untrusted text into an HTML context using .innerHTML. The safest, most robust fix is to escape title for HTML meta-characters (<, >, &, ", etc.) before embedding it into the string. The best way to implement this is to create a utility function to escape HTML, and use it on title in the template string.
Detailed steps:
- Implement an
escapeHtmlfunction in the file (preferably at module-scope if not available elsewhere) that converts"&","<",">",'"', and'to their corresponding HTML entities. - Use
escapeHtml(title)(instead oftitle) in the template literal on line 54, ensuring that any unexpected input is displayed as text, not HTML. - No external dependencies are required for this, and the change should be limited to the scope of the existing method in the file shown.
Suggested changeset
1
src/panel-layout-engine.ts
| @@ -17,6 +17,19 @@ | ||
| resizeHandler?: (e: MouseEvent) => void; // Mouse down handler for resizing | ||
| } | ||
|
|
||
| /** | ||
| * Escape a string for insertion into HTML context. | ||
| * Converts &, <, >, ", and ' to HTML entities. | ||
| */ | ||
| function escapeHtml(str: string): string { | ||
| return String(str) | ||
| .replace(/&/g, "&") | ||
| .replace(/</g, "<") | ||
| .replace(/>/g, ">") | ||
| .replace(/"/g, """) | ||
| .replace(/'/g, "'"); | ||
| } | ||
|
|
||
| export class PanelLayoutEngine extends LayoutEngine { | ||
| public static GRID_SIZE = 25; | ||
| public static DEFAULT_COL_COUNT = 2; | ||
| @@ -51,7 +64,7 @@ | ||
| header.className = "sa-panel-layout__item-header"; | ||
| const title = item.dataset.title || (item.querySelector(".sa-question__title") as HTMLElement)?.innerText || "Panel"; | ||
| header.innerHTML = ` | ||
| <div class="sa-panel-layout__item-title">${title}</div> | ||
| <div class="sa-panel-layout__item-title">${escapeHtml(title)}</div> | ||
| <div class="sa-panel-layout__item-coords">${panel.x},${panel.y} | ${panel.width}×${panel.height}</div> | ||
| `; | ||
| item.prepend(header); |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.