Add script to generate versions.adoc and update for 3.5 #1008
Conversation
Adds a script/template which allows us to generate the versions derived from the release manifest, hopefully this will be less effort and less error-prone than manual updates
diconico07
left a comment
diconico07
left a comment
There was a problem hiding this comment.
Mostly usability comments. This will be a really nice addition 👍
| RELEASE_BRANCH=${RELEASE_BRANCH_:-"main"} | ||
|
|
||
| echo "Downloading release manifest for ${RELEASE_BRANCH} branch" | ||
| curl "https://src.opensuse.org/suse-edge/Factory/raw/branch/${RELEASE_BRANCH}/release-manifest-image/release_manifest.yaml" -o _release_manifest.yaml |
There was a problem hiding this comment.
Would rather use the rendered version from registry.opensuse.org here, just to avoid the templating issues
There was a problem hiding this comment.
Agreed that will make it simpler
| :version-elemental-operator-chart: {{ release_manifest_elemental_version }} | ||
| :version-elemental-operator-crds-chart: {{ release_manifest_elemental_crd_version }} | ||
| :version-endpoint-copier-operator-chart: {{ release_manifest_eco_version }} | ||
| :version-fleet-chart: 108.0.1+up0.14.1 |
There was a problem hiding this comment.
I'd group all the "manually handled ones" to make them more visible
| :version-neuvector-crd-chart: {{ release_manifest_neuvector_crd_version }} | ||
| :version-neuvector-dashboard-extension-chart: {{ release_manifest_neuvector_dashboard_version }} | ||
| :version-rancher-chart: {{ release_manifest_rancher_version }} | ||
| :version-rancher-turtles-chart: 304.0.6+up0.24.0 |
There was a problem hiding this comment.
I guess this one should just get replaced with the turtles providers chart.
There was a problem hiding this comment.
Yes, but I was planning to handle that in #996
| VERSIONS_TEMPLATE=${VERSIONS_TEMPLATE:-"../asciidoc/edge-book/versions.adoc.j2"} | ||
| VERSIONS_FILE=${VERSIONS_FILE:-"../asciidoc/edge-book/versions.adoc"} | ||
| # Generating ${VERSIONS_FILE} | ||
| jinja2 ${VERSIONS_TEMPLATE} _release_manifest.yaml | tee ${VERSIONS_FILE} |
There was a problem hiding this comment.
Not fond of the use of jinja2 cli, as it's not packaged in openSUSE.
| @@ -0,0 +1,18 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
since we are rendering using python and jinja2, would make it easier to have a python script I think.
There was a problem hiding this comment.
Yeah fair point, I can re-write it in python which will probably be cleaner
2 participants
Adds a script/template which allows us to generate the versions derived from the release manifest, hopefully this will be less effort and less error-prone than manual updates
Note this is a first step which requires running the script manually - in future we can add a check job to enforce its use, and potentially look at ways to automate the updates via a renovate type flow.