-
Notifications
You must be signed in to change notification settings - Fork 42
DOCTEAM-1969 - addressed image width issue and the cross reference title #846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Ranjini M N <[email protected]>
asciidoc/quickstart/elemental.adoc
Outdated
| image::installing-elemental-extension-2.png[Installing Elemental extension 2,scaledwidth=100%] | ||
| + | ||
| image::installing-elemental-extension-2.png[Installing Elemental extension 2,scaledwidth=85%] | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These appear to also be relevant to main which will soon be branched for 3.4 - can we propose this part to main, then backport please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was addressed via #852 (thanks!) so I'd suggest you cherry-pick the commit from main/release-3.4 e.g with git cherry-pick -x then rebase this branch so the second commit only contains the other changes.
| ---- | ||
| + | ||
| [#arm64-mgmt-cluster] | ||
| .Deploy arm64 downstream cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hardys This content has been removed from the main branch. Is this relevant for previous releases? Should I retain this content for 3.1, 3.2, and 3.3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this content has been removed for main/3.4, but it should be retained for 3.3
…suse-edge#800) * list of open ports added to "asciidoc/product/atip-requirements.adoc" Signed-off-by: Antonio Alonso Alarcon <[email protected]> * Applied changes from PR#800 ranjinimn suggestions/proposals (first review) Signed-off-by: Antonio Alonso Alarcon <[email protected]> * Applied changes from PR#800 review - hardys comments Signed-off-by: Antonio Alonso Alarcon <[email protected]> --------- Signed-off-by: Antonio Alonso Alarcon <[email protected]> (cherry picked from commit 5466634)
…e are Ingress ports (suse-edge#815) Signed-off-by: Antonio Alonso Alarcon <[email protected]> (cherry picked from commit 3aa4bb5)
Signed-off-by: Ranjini M N <[email protected]>
(cherry picked from commit 6de6b01)
Also included the metal3 tips and tricks section that was missing (cherry picked from commit aed5834)
Signed-off-by: Ranjini M N <[email protected]>
Currently issues like that mentioned in suse-edge#908 won't be caught because we're not testing stable branch PRs (cherry picked from commit 7229178)
This was renamed in 6de6b01 and somehow missed in the suse-edge#890 backport of suse-edge#887
(cherry picked from commit e22a4c1)
(cherry picked from commit a81b56a)
…k from translators Signed-off-by: Ranjini M N <[email protected]>
|
There were way too many conflicts in this. Closing this and creating a new pull request. |
Edited only 3.3 version of the documentation. Based on the feedback, I will make the changes to the other versions of the document.
Issue: Cross reference - Cross ref format to a para without a title looks odd. See source English, section 42.2.1, page 461.
Changes: Added a title to the section
Issue: In Spanish and Brazilian Portuguese 3.3 books the 100% value was not enough to stop the images from overlaying text in section 2.5.1 (page 32). Here I set the value to 85% and I set it in the Weblate TM so that it would be 'remembered'. - >
Changes: Edited the scaledwidth to 85%. The rest of the images were fixed earlier this month https://github.com/suse-edge/suse-edge.github.io/pull/795/files