Skip to content

Conversation

@ranjinimn
Copy link
Collaborator

Closes #620

Edited content based on the information in the issue (#947)

@ranjinimn ranjinimn requested a review from e-minguez November 6, 2025 16:12
e-minguez
e-minguez previously approved these changes Nov 11, 2025
Co-authored-by: Eduardo Mínguez <[email protected]>
@hardys
Copy link
Contributor

hardys commented Nov 14, 2025

Please can we fix the EOF issue on main before merging, then we can mark this as a combined backport of #947 and the EOF fix - otherwise the EOF issue will still exist in the 3.5 docs when we branch

@hardys
Copy link
Contributor

hardys commented Nov 14, 2025

@e-minguez is the EOF space issue shell specific? I just tried it on zsh and bash and it works fine with or without the space?

@e-minguez
Copy link
Collaborator

@e-minguez is the EOF space issue shell specific? I just tried it on zsh and bash and it works fine with or without the space?

I promised I tested it and it didn't worked... now I've tested it again with zsh and bash and it works. Apologies for the noise (again)

@hardys
Copy link
Contributor

hardys commented Nov 14, 2025

@e-minguez is the EOF space issue shell specific? I just tried it on zsh and bash and it works fine with or without the space?

I promised I tested it and it didn't worked... now I've tested it again with zsh and bash and it works. Apologies for the noise (again)

Ok, definitely good to check these things - as e.g leading space for the closing EOF will cause problems, but if we're agreed that in this case it's cosmetic lets merge the backports and not block on the change to main, thanks!

@hardys hardys requested a review from e-minguez November 14, 2025 11:40
@hardys hardys merged commit d8d7053 into suse-edge:release-3.4 Nov 14, 2025
1 check passed
@ranjinimn ranjinimn deleted the cherry-pick-620-3.4 branch November 14, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants