removed unused data query and corrected health query#1
Open
Clearwood wants to merge 2 commits intosushiswap:v2from
Open
removed unused data query and corrected health query#1Clearwood wants to merge 2 commits intosushiswap:v2from
Clearwood wants to merge 2 commits intosushiswap:v2from
Conversation
omakasebar
reviewed
Oct 29, 2020
omakasebar
left a comment
omakasebar
left a comment
There was a problem hiding this comment.
Just want to make sure there are no side effects in removing this query
| } | ||
| ` | ||
|
|
||
| export const V1_DATA_QUERY = gql` |
There was a problem hiding this comment.
is V1_DATA_QUERY used in other places? I'm assuming not since V1 is largely deprecated. If this is the case we can remove it and the this PR can note its removal for posterity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I removed the unused Queries to UniSwap V1, the configuration files for VSCode and corrected the health check to the correct SubGraph.