Separate collection interval for Oracle top_query collection #4
+135
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XSAM
reviewed
Nov 20, 2025
| topNCollectionErrors := s.collectTopNMetricData(ctx, logs, currentCollectionTime, lookbackTimeCounter) | ||
| if topNCollectionErrors != nil { | ||
| scrapeErrors = append(scrapeErrors, topNCollectionErrors) | ||
| } |
There was a problem hiding this comment.
Could we move s.lastExecutionTimestamp = collectionTime here? so the early returned collectTopNMetricData can still update the last execution time.
Currently, if the hits is zero, then the last execution time won't get updated.
Owner
Author
There was a problem hiding this comment.
Thats a good point. I had multiple thoughts about this too.
I did it this way to make the first collection happen as early as possible, otherwise it would happen only at the end of first 60 seconds. But it's nothing huge. Let me check if there could be some work around.
XSAM
reviewed
Nov 20, 2025
receiver/oracledbreceiver/scraper.go
Outdated
| return int(s.topQueryCollectCfg.CollectionInterval.Seconds()) | ||
| } | ||
|
|
||
| const vsqlRefreshLagSec = 10 * time.Second // Buffer to account for v$sql maximum refresh latency |
There was a problem hiding this comment.
Could you explain or update the comment for the buffer design? Why do we need to go back further for 10 seconds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DBMon - Internal PR
This PR is to introduce the capability in Oracle receiver to have separate collection interval for top_query.
This feature is already existing in sql server.
Only difference in Oracle's implementation is that the
lookbackTimefor each collection is calculated dynamically, and the user cannot provide a value through config. SQL server receiver has an option for this to be configured manually.A
vsqlRefreshLagSecof 10 seconds is added to the lookbackTime to offset the refresh lag in v$sql table( https://docs.oracle.com/en/database/oracle/oracle-database/21/refrn/V-SQL.html#:~:text=they%20are%20updated%20every%205%20seconds )