perf: avoid garbage colection in token type utils #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the token type functions such that they no longer create a new array of token types every time, but instead use normal equality checks and `includes` on a pre-computed set. `acorn` token types can be mutated, but we already take a snapshot of the types at time of creating our `AcornTypeScript`. Due to this, we can just store the `Object.values` one time up front and call `includes` on the same array later. All of this means we no longer cause garbage collection (for creating a single-use array) and we save CPU cycles on calling `includes` against sets if we already matched.
🦋 Changeset detectedLatest commit: 2c51818 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Looks like linting is failing on file that was not modified here 🤔 |
fixed in |
baseballyama
approved these changes
Sep 26, 2025
dummdidumm
reviewed
Sep 26, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the token type functions such that they no longer create a
new array of token types every time, but instead use normal equality
checks and
includeson a pre-computed set.acorntoken types can be mutated, but we already take a snapshot ofthe types at time of creating our
AcornTypeScript. Due to this, we canjust store the
Object.valuesone time up front and callincludesonthe same array later.
All of this means we no longer cause garbage collection (for creating a
single-use array) and we save CPU cycles on calling
includesagainstsets if we already matched.