Skip to content

Conversation

dummdidumm
Copy link
Member

A simple, string-based migration for sveltejs/kit#13140 (tested on that repo, zero false-positives, less than five false negatives)

We can switch to using the Svelte parser if people prefer that to get a bit better with regards to only actually transforming identifiers, but to me this seems to work fine.

A simple, string-based migration for sveltejs/kit#13140 (tested on that repo, zero false-positives, less than five false negatives)
Copy link

changeset-bot bot commented Dec 12, 2024

🦋 Changeset detected

Latest commit: 25a948b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte-migrate Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Dec 12, 2024

Open in Stackblitz

npm i https://pkg.pr.new/sveltejs/cli/sv@354
npm i https://pkg.pr.new/sveltejs/cli/svelte-migrate@354

commit: 25a948b

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-cli-354-svelte.vercel.app/

this is an automated message

@manuel3108
Copy link
Member

Merged main here after merging #349 to have more sensible ordering of the migrations in the readme and website. Added the new migration to docs. Feel free to change the wording

@Rich-Harris
Copy link
Member

Should we make this an app-state migration and include navigating and updated?

@dummdidumm
Copy link
Member Author

This already contains migrations for navigating (though the one with current on it) and updated - page-state is a misnomer, you're right that we should rename it to app-state

@Rich-Harris Rich-Harris changed the title feat: add page-state migration feat: add app-state migration Dec 16, 2024
@Rich-Harris Rich-Harris marked this pull request as ready for review December 16, 2024 21:15
@Rich-Harris Rich-Harris merged commit 87e895f into main Dec 16, 2024
8 checks passed
@Rich-Harris Rich-Harris deleted the page-state-migration branch December 16, 2024 21:39
@github-actions github-actions bot mentioned this pull request Dec 16, 2024
@benmccann
Copy link
Member

Heads up that this only found 9 out of 22 occurrences of $app/stores when I ran it on a real project. I filed an issue here: #368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants