Skip to content

chore: improved storybook prefetching #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 3, 2025

Conversation

manuel3108
Copy link
Member

Relates #622
Relates sveltejs/svelte-ecosystem-ci#32

In direct comparison to #622 this has the disadvantage, that this also run's locally. We could check via the CI env variable, but I don't think that would help to reproduce pipeline failures locally. On the other hand, this is an improvement in comparison to #622 because it allows our tests to be run everywhere, without requiring explicit setup. This is in example the case in svelte-ecosystem-ci (sveltejs/svelte-ecosystem-ci#32)

If this works the way I think it should (I will check in the pipeline), I would personally consider this as a slight improvement.

Copy link

changeset-bot bot commented Aug 2, 2025

⚠️ No Changeset found

Latest commit: de6bed8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Aug 2, 2025

Open in StackBlitz

npx https://pkg.pr.new/sveltejs/cli/sv@660
npx https://pkg.pr.new/sveltejs/cli/svelte-migrate@660

commit: de6bed8

@manuel3108 manuel3108 marked this pull request as ready for review August 3, 2025 05:52
@AdrianGonz97 AdrianGonz97 merged commit 278022e into main Aug 3, 2025
7 checks passed
@AdrianGonz97 AdrianGonz97 deleted the chore/storybook-prefetching branch August 3, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants