chore(create): recommend the kit.typescript.config setting instead of copying from the generated config
#668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
eltigerchino
commented
Aug 14, 2025
🦋 Changeset detectedLatest commit: 12cd03c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
manuel3108
changed the title
kit.typescript.config setting instead of copying from the generated configkit.typescript.config setting instead of copying from the generated config
manuel3108
changed the title
kit.typescript.config setting instead of copying from the generated configkit.typescript.config setting instead of copying from the generated config
manuel3108
changed the title
kit.typescript.config setting instead of copying from the generated configkit.typescript.config setting instead of copying from the generated config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accompanying sveltejs/kit#14026
This PR changes the comment in the create template's tsconfig.json file to prefer the kit config setting for extending the tsconfig file instead of overriding the includes and excludes settings.
Open to a better explanation/wording of why the setting should be used.