Skip to content

Conversation

jycouet
Copy link
Contributor

@jycouet jycouet commented Sep 18, 2025

Closes: #521
Closes: #705
Closes: #714


Copy link

changeset-bot bot commented Sep 18, 2025

🦋 Changeset detected

Latest commit: 87235e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Sep 18, 2025

Open in StackBlitz

npx https://pkg.pr.new/sveltejs/cli/sv@718
npx https://pkg.pr.new/sveltejs/cli/svelte-migrate@718

commit: 87235e8

@jycouet
Copy link
Contributor Author

jycouet commented Sep 18, 2025

@hyunbinseo you might want to try npx https://pkg.pr.new/sveltejs/cli/sv@718 and play with pnpm-workspace.

@hyunbinseo
Copy link
Contributor

Seems to be working as expected:

pnpm init

Manually pnpm-workspace.yaml with monorepo setup

packages:
  - packages/*

onlyBuiltDependencies:
  - esbuild
mkdir packages/hello
cd packages/hello
pnpm dlx https://pkg.pr.new/sveltejs/cli/sv@718 create .
┌  Welcome to the Svelte CLI! (v0.9.5)
│
◇  Which template would you like?
│  SvelteKit minimal
│
◇  Add type checking with TypeScript?
│  Yes, using TypeScript syntax
│
◆  Project created
│
◇  What would you like to add to your project? (use arrow keys / space bar)
│  tailwindcss
│
◇  Which plugins would you like to add?
│  none
│
◆  Successfully setup add-ons
│
◇  Which package manager do you want to install dependencies with?
│  pnpm
│
◆  Successfully installed dependencies
│                                                                                                                                      
◇  What's next? ───────────────────────────────╮                                                                                       
│                                              │                                                                                       
│  📁 Project steps                            │                                                                                       
│                                              │                                                                                       
│    1: pnpm run dev --open                    │                                                                                       
│                                              │
│  To close the dev server, hit Ctrl-C         │
│                                              │
│  Stuck? Visit us at https://svelte.dev/chat  │
│                                              │
├──────────────────────────────────────────────╯
│
└  You're all set!
  packages:
    - packages/*
    - sites/*
  
  onlyBuiltDependencies:
    - esbuild
+   - '@tailwindcss/oxide'

Copy link
Member

@manuel3108 manuel3108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manuel3108 manuel3108 merged commit 807016d into sveltejs:perf/tests-v7 Sep 24, 2025
7 checks passed
@manuel3108
Copy link
Member

manuel3108 commented Sep 24, 2025

Why the heck did this not close the issues?
Edit: Oh maybe because of the colon after the magic keyword. Closing manually

@jycouet
Copy link
Contributor Author

jycouet commented Sep 24, 2025

No, I guess that it's because it was a PR against another branch, not against main. (I did mention this in the description ^^)

@hyunbinseo
Copy link
Contributor

Thanks for the great work! Why are the related issues reopened?

@manuel3108
Copy link
Member

Because this PR was not targeting main for the moment. Will probably be closed soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants