-
-
Notifications
You must be signed in to change notification settings - Fork 57
feat(cli): pnpm config will now be stored in pnpm-workspace.yaml #718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): pnpm config will now be stored in pnpm-workspace.yaml #718
Conversation
🦋 Changeset detectedLatest commit: 87235e8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
@hyunbinseo you might want to try |
Seems to be working as expected: pnpm init Manually packages:
- packages/*
onlyBuiltDependencies:
- esbuild mkdir packages/hello
cd packages/hello
pnpm dlx https://pkg.pr.new/sveltejs/cli/sv@718 create .
packages:
- packages/*
- sites/*
onlyBuiltDependencies:
- esbuild
+ - '@tailwindcss/oxide' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Why the heck did this not close the issues? |
No, I guess that it's because it was a PR against another branch, not against main. (I did mention this in the description ^^) |
Thanks for the great work! Why are the related issues reopened? |
Because this PR was not targeting main for the moment. Will probably be closed soon |
Closes: #521
Closes: #705
Closes: #714
yaml
package (reco by e18e https://e18e.dev/guide/replacement-guides/js-yaml.html)pnpm-workspace.yaml
from[email protected]
(7 months old). If not fallback topackage.json
config like before this PR.