Skip to content

Conversation

baseballyama
Copy link
Member

No description provided.

Copy link

pkg-pr-new bot commented Jan 12, 2025

Open in Stackblitz

npm i https://pkg.pr.new/eslint-plugin-svelte@1010

commit: 0c0198f

@ota-meshi
Copy link
Member

Thank you for the PR.
But I still don't understand. Can you tell me why this change is necessary?

@ota-meshi
Copy link
Member

Thank you for the explanation.

But I don't think the compiler will report the duplicates 🤔

<svelte:options runes />
<button on:click={foo} on:click={foo}>Hello!</button>

https://svelte.dev/playground/ac1bc2094524431abc508168f35e9f29?version=5.17.4

@baseballyama
Copy link
Member Author

baseballyama commented Jan 14, 2025

Ohhhhhhh

Hum, But this will generate another warning, which the user will need to correct anyway.
But anyway, yet this rule was found to be legitimate.😇

Using on:click to listen to the click event is deprecated. Use the event attribute onclick instead
https://svelte.dev/e/event_directive_deprecated (event_directive_deprecated)

@baseballyama
Copy link
Member Author

We need to run this rule even in Svelte5 with runes.

@baseballyama baseballyama deleted the cho/no-dupe-on-directives branch January 16, 2025 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants