feat: detect version information from node_modules for pnpm’s catalog
#1063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baseballyama
changed the title
package.json, like pnpm’s catalogpackage.json, like pnpm’s catalog
baseballyama
force-pushed
the
feat/support-pnpm-catalog
branch
from
dc10495 to
173b5be
Compare
Try the Instant Preview in Online PlaygroundInstall the Instant Preview to Your LocalPublished Instant Preview Packages:
|
baseballyama
force-pushed
the
feat/support-pnpm-catalog
branch
from
173b5be to
3510a29
Compare
🦋 Changeset detectedLatest commit: 42100df The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
… in package.json, like pnpm’s catalog
baseballyama
force-pushed
the
feat/support-pnpm-catalog
branch
from
3510a29 to
74a3f23
Compare
|
I have confirmed that it works correctly in my project using pnpm catalog. |
baseballyama
changed the title
package.json, like pnpm’s catalognode_modules for pnpm’s catalog
|
I just realized, how about getting the version like this: import {VERSION} from "svelte/compiler"I think it will also work with Svelte v3. |
I can’t believe it. How did I overlook this until now 😇. I have confirmed that this works even with the 5.0.0-next version. |
|
I updated the PR according to your suggegstion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this issue while using pnpm catalog in our project.