Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/vast-clouds-accept.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'eslint-plugin-svelte': patch
---

fix: handle `<script module>` in `valid-prop-names-in-kit-pages` rule
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,23 @@ function checkProp(
}
}

function isModuleScript(node: AST.SvelteAttribute) {
// <script context="module">
if (
node.key.name === 'context' &&
node.value.some((v) => v.type === 'SvelteLiteral' && v.value === 'module')
) {
return true;
}

// <script module>
if (node.key.name === 'module' && node.value.length === 0) {
return true;
}

return false;
}

export default createRule('valid-prop-names-in-kit-pages', {
meta: {
docs: {
Expand All @@ -54,12 +71,7 @@ export default createRule('valid-prop-names-in-kit-pages', {
// <script>
'Program > SvelteScriptElement > SvelteStartTag': (node: AST.SvelteStartTag) => {
// except for <script context="module">
isScript = !node.attributes.some(
(a) =>
a.type === 'SvelteAttribute' &&
a.key.name === 'context' &&
a.value.some((v) => v.type === 'SvelteLiteral' && v.value === 'module')
);
isScript = !node.attributes.some((a) => a.type === 'SvelteAttribute' && isModuleScript(a));
},

// </script>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<script module>
export let data;
export let errors;
export let foo;
export let bar;
</script>

{data}, {errors}, {foo}, {bar}
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<script module>
export const { data, errors } = { data: {}, errors: {} };
</script>

{data}, {errors}
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"settings": {
"svelte": {
"kit": {
"files": {
"routes": "tests/fixtures"
}
}
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"settings": {
"svelte": {
"kit": {
"files": {
"routes": "tests/fixtures"
}
}
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<script module>
export const { data2: data, errors2: errors } = { data2: {}, errors2: {} };
</script>

{data}, {errors}
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"settings": {
"svelte": {
"kit": {
"files": {
"routes": "tests/fixtures"
}
}
}
}
}