Skip to content

fix(no-useless-mustaches): Wrong auto-fix for quoted mustaches #1140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2025
Merged

fix(no-useless-mustaches): Wrong auto-fix for quoted mustaches #1140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94068f8
fix(no-useless-mustaches): Wrong auto-fix for quoted mustaches
ota-meshi Mar 18, 2025
07d9868
Create wise-fireants-obey.md
ota-meshi Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/wise-fireants-obey.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"eslint-plugin-svelte": patch
---

fix(no-useless-mustaches): Wrong auto-fix for quoted mustaches
11 changes: 9 additions & 2 deletions packages/eslint-plugin-svelte/src/rules/no-useless-mustaches.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,14 +142,21 @@ export default createRule('no-useless-mustaches', {
node.parent.key.range[1],
node.parent.value[0].range[0]
);
if (!div.endsWith('"') && !div.endsWith("'")) {
const quote = div.endsWith('"') ? 'quot' : div.endsWith("'") ? 'apos' : null;
if (!quote) {
return [
fixer.insertTextBefore(node.parent.value[0], '"'),
fixer.replaceText(node, unescaped.replace(/"/gu, '"')),
fixer.insertTextAfter(node.parent.value[node.parent.value.length - 1], '"')
];
}
return fixer.replaceText(node, unescaped);

return fixer.replaceText(
node,
quote === 'quot'
? unescaped.replace(/"/gu, '"')
: unescaped.replace(/'/gu, ''')
);
}
return fixer.replaceText(node, unescaped.replace(/</gu, '&lt;').replace(/>/gu, '&gt;'));
}
Expand Down
16 changes: 16 additions & 0 deletions ...-plugin-svelte/tests/fixtures/rules/no-useless-mustaches/invalid/quote-test02-errors.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
- message: Unexpected mustache interpolation with a string literal value.
line: 2
column: 17
suggestions: null
- message: Unexpected mustache interpolation with a string literal value.
line: 4
column: 17
suggestions: null
- message: Unexpected mustache interpolation with a string literal value.
line: 6
column: 17
suggestions: null
- message: Unexpected mustache interpolation with a string literal value.
line: 8
column: 17
suggestions: null
8 changes: 8 additions & 0 deletions ...plugin-svelte/tests/fixtures/rules/no-useless-mustaches/invalid/quote-test02-input.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<!--prettier-ignore-->
<div data-text="{'\'"'}" />
<!--prettier-ignore-->
<div data-text="{"'\""}" />
<!--prettier-ignore-->
<div data-text='{'\'"'}' />
<!--prettier-ignore-->
<div data-text='{"'\""}' />
8 changes: 8 additions & 0 deletions ...lugin-svelte/tests/fixtures/rules/no-useless-mustaches/invalid/quote-test02-output.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<!--prettier-ignore-->
<div data-text="'&quot;" />
<!--prettier-ignore-->
<div data-text="'&quot;" />
<!--prettier-ignore-->
<div data-text='&apos;"' />
<!--prettier-ignore-->
<div data-text='&apos;"' />
Loading