Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,12 @@ export default createRule('no-unnecessary-state-wrap', {
const options = context.options[0] ?? {};
const additionalReactiveClasses = options.additionalReactiveClasses ?? [];
const allowReassign = options.allowReassign ?? false;
const { globalScope } = context.sourceCode.scopeManager;
if (globalScope == null) {
return {};
}

const referenceTracker = new ReferenceTracker(context.sourceCode.scopeManager.globalScope!);
const referenceTracker = new ReferenceTracker(globalScope);
const traceMap: Record<string, Record<string, boolean>> = {};
for (const reactiveClass of REACTIVE_CLASSES) {
traceMap[reactiveClass] = {
Expand All @@ -79,8 +83,10 @@ export default createRule('no-unnecessary-state-wrap', {
});

function isReassigned(identifier: TSESTree.Identifier): boolean {
const variable = context.sourceCode.scopeManager.getDeclaredVariables(identifier.parent)[0];
return variable.references.some((ref) => {
const references = context.sourceCode.scopeManager
.getDeclaredVariables(identifier.parent)
.flatMap((v) => v.references);
return references.some((ref) => {
return ref.isWrite() && ref.identifier !== identifier;
});
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"options": [
{
"allowReassign": true
}
]
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<script lang="ts">
import { SvelteSet } from 'svelte/reactivity';
import Bug3 from './Bug3.svelte';

let svelteSet = $state(new SvelteSet<number>([]));
</script>

<Bug3 bind:svelteSet />
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"options": [
{
"allowReassign": true
}
]
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<script lang="ts">
import { SvelteSet } from 'svelte/reactivity';
import Bug3 from './Bug3.svelte';

let svelteSet = $state(new SvelteSet<number>([]));
</script>

<Bug3 bind:svelteSet={() => svelteSet, (v) => (svelteSet = v)} />
Loading