feat: replaced no-navigation-without-base with no-navigation-without-resolve #1289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: de424c6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Try the Instant Preview in Online PlaygroundInstall the Instant Preview to Your LocalPublished Instant Preview Packages:
|
marekdedic
force-pushed
the
no-navigation-without-resolve
branch
3 times, most recently
from
3cc4ae5 to
dbbf1da
Compare
marekdedic
force-pushed
the
no-navigation-without-resolve
branch
2 times, most recently
from
ed885b7 to
592b568
Compare
|
Hey @ota-meshi @baseballyama, sorry to ping you, but I'm getting the same CI error as in #1287, I'm not sure if I'm doing something wrong or it's another issue with the repo... ? |
|
Also, I'll be away for the next 2 weeks, so I won't be able to respond or fix anything. But I've enabled editing by maintainers, so if you want, feel free to edit the PR and merge it while I'm away :) |
marekdedic
force-pushed
the
no-navigation-without-resolve
branch
from
592b568 to
a911940
Compare
marekdedic
force-pushed
the
no-navigation-without-resolve
branch
from
a911940 to
de424c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1277
Unfortunately in order to really make sense, the rule needed a new name, so we have yet another deprecated rule :/ Maybe remove them in a major release?