Skip to content

Conversation

marekdedic
Copy link
Contributor

@marekdedic marekdedic commented Sep 4, 2025

Fixes the issue mentioned in #1319 (comment)

But this is too interconnected with #1322, @ota-meshi can we get that one merged first please and I will then rebase this one :)

Copy link

changeset-bot bot commented Sep 4, 2025

🦋 Changeset detected

Latest commit: 85a8111

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-svelte Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 4, 2025

Try the Instant Preview in Online Playground

ESLint Online Playground

Install the Instant Preview to Your Local

npm i https://pkg.pr.new/eslint-plugin-svelte@85a8111

Published Instant Preview Packages:

View Commit

@marekdedic marekdedic force-pushed the no-navigation-without-resolve-property-shorthand branch 4 times, most recently from 232b605 to 7222885 Compare September 21, 2025 09:16
@marekdedic marekdedic marked this pull request as ready for review September 21, 2025 09:21
@marekdedic
Copy link
Contributor Author

This one is now ready :)

Copy link
Member

@baseballyama baseballyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does it only check href? Shouldn’t the following patterns also be checked?

<script>
  const validLink = resolve("/foo");
  const invalidLink = "/foo";
</script>
<a href={validLink}>Click me!</a>
<a href={invalidLink}>Click me!</a>

@marekdedic
Copy link
Contributor Author

Those are already checked without this PR :) This one just adds support for the shorthand...

@marekdedic marekdedic force-pushed the no-navigation-without-resolve-property-shorthand branch from 7222885 to 70a5aac Compare September 23, 2025 14:46
@marekdedic marekdedic force-pushed the no-navigation-without-resolve-property-shorthand branch from 70a5aac to 3243dbb Compare October 5, 2025 08:16
@marekdedic marekdedic requested a review from ota-meshi October 5, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants