Skip to content

Conversation

teemingc
Copy link
Member

splitting up some of the changes in #13427 into separate PRs

This PR moves esbuild to a dev dep since we no longer use it during build to bundle the server into a single worker file, we only use it to bundle worktop into the worker before we publish the package. This also removes the @types/ws from the dev deps since it's not in use and may have been added accidentally?


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Mar 24, 2025

🦋 Changeset detected

Latest commit: 9870945

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

@teemingc teemingc changed the title chore: move esbuild to a devDependency chore: move esbuild to devDependency Mar 24, 2025
@benmccann benmccann merged commit b54e6b2 into main Mar 24, 2025
15 of 16 checks passed
@benmccann benmccann deleted the cloudflare-esbuild-dev-dep branch March 24, 2025 15:36
@github-actions github-actions bot mentioned this pull request Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants