Skip to content

remove deprecated tag from kit.files.src #14211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

AndersRobstad
Copy link

In this PR the kit.files.src option was added to the config, however it was also marked as @deprecated. I'm guessing this was a mistake since my understanding of the PR was that this was the new way of defining the src folder.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Aug 14, 2025

⚠️ No Changeset found

Latest commit: 8ba57da

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@eltigerchino eltigerchino linked an issue Aug 14, 2025 that may be closed by this pull request
@Rich-Harris
Copy link
Member

Thank you but nope, it's intentional. We're deprecating all these options, but we also need a way to target the src directory (so that we can walk it to discover remote function files outside lib and routes, for example). It wouldn't make sense to hardcode src as long as people have config like this...

kit: {
  files: {
    lib: 'source/lib',
    routes: 'source/routes'
  }
}

...so this is the compromise we settled on.

@AndersRobstad
Copy link
Author

Thank you but nope, it's intentional. We're deprecating all these options, but we also need a way to target the src directory (so that we can walk it to discover remote function files outside lib and routes, for example). It wouldn't make sense to hardcode src as long as people have config like this...

kit: {
  files: {
    lib: 'source/lib',
    routes: 'source/routes'
  }
}

...so this is the compromise we settled on.

Ahaaa, gottchu! Misunderstood the intent of adding the src field 🙌

@olgakozoriz
Copy link

could we at least leave routes folder configurable?
It's a common case, when we have shared $lib, and 5-10 different /routes entry points in one repo.
We just put different ENV variable, like VITE_ROUTE=route_1|route_23 and produce different parts of an app, that are deployed to different domain.

I also don't see lots of sense in moving $lib folder to another place, but multiple routes folders present pretty often.

@assiyakh-blip
Copy link

We produce lots of different ad onboarding flows, and also implement them as different routes in one repo. Like one lib folder, where identics and common staff stay. And 34 different route folders with different landings and custom onboarding flows for different domains.
It means that we are hardly (at least 34 times) dependent on that feature:)

@Rich-Harris
Copy link
Member

I've opened #14240 for this discussion — let's continue over there. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting kit.files.src results in deprecation message
4 participants