Skip to content

fix: false positive csrf error in remote functions #14309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

fix: false positive csrf error in remote functions #14309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aaf20f5
added csrf check
l0uisgrange Aug 25, 2025
d2edf40
added changeset
l0uisgrange Aug 25, 2025
e411abb
changeset name
l0uisgrange Aug 25, 2025
a4083e8
changeset name again
l0uisgrange Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/twenty-parrots-invent.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

fix: false positive `csrf` error in remote functions
2 changes: 1 addition & 1 deletion packages/kit/src/runtime/server/respond.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ export async function internal_respond(request, options, manifest, state) {
const request_origin = request.headers.get('origin');

if (remote_id) {
if (request.method !== 'GET' && request_origin !== url.origin) {
if (options.csrf_check_origin && request.method !== 'GET' && request_origin !== url.origin) {
const message = 'Cross-site remote requests are forbidden';
return json({ message }, { status: 403 });
}
Expand Down
Loading