-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat: allow changing response http status code from handleError
#14919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
justinba1010
wants to merge
14
commits into
sveltejs:main
Choose a base branch
from
justinba1010:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+130
−29
Open
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
73dac27
feat(#14442): allow custom http status codes
justinba1010 d650e57
Apply suggestions from code review
justinba1010 aa9ca9e
Update packages/kit/test/apps/basics/test/server.test.js
justinba1010 5964903
Update packages/kit/src/utils/error.js
justinba1010 5c3a1f0
Update packages/kit/test/apps/basics/test/server.test.js
justinba1010 419662e
lint
justinba1010 ea3ff07
Merge branch 'main' into main
justinba1010 dcea461
new implementation
justinba1010 70d8532
remove unneccessary
justinba1010 78deb46
catch all places where status code is set
justinba1010 4a956e9
update types
justinba1010 64d2917
checkout error.js
justinba1010 9ca1978
improve styling
justinba1010 e1a5954
Merge branch 'main' into main
teemingc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@sveltejs/kit': minor | ||
| --- | ||
|
|
||
| Allow Custom HTTP Status Codes | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
packages/kit/test/apps/basics/src/routes/errors/custom-error/+server.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| class CustomError extends Error { | ||
| constructor(message, errorOpts) { | ||
| super(message, errorOpts); | ||
| this.status = 422; | ||
| } | ||
| } | ||
|
|
||
| export function GET() { | ||
| throw new CustomError('Custom error'); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.