Skip to content

Conversation

@teemingc
Copy link
Member

closes #12592

WIP. Doing some testing with Vercel deployments using the pkg.pr.new version


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link

changeset-bot bot commented Nov 19, 2025

⚠️ No Changeset found

Latest commit: 8d51186

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dummdidumm
Copy link
Member

While this is promising, I believe there were some questions more generally about whether or not this is the right direction, @Rich-Harris might know more from Vercel-internal discussions

@teemingc
Copy link
Member Author

teemingc commented Nov 20, 2025

Yeah, I'm also not sure if query params will be sufficient and if it can work in tandem with cookies so that at least the modules loaded in by Vite don't cause a fetch error when they fetch a version that doesn't exist. There are a few more places in Kit I'll have to discover because we construct the import paths manually in some places. Trying to learn from withastro/astro#14543

cc: @serhalp since this may or may not affect how it's implemented for the Netlify adapter. Maybe the concerns Simon is talking about only pertain to Vercel.

Vercel's documentation implies that only one method is supported at a time https://vercel.com/docs/skew-protection#supported-frameworks but I think Netlify supports a combination of methods (cookie, query param, header)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Why is __vdpl cookie used for Skew Protection in Vercel instead of x-deployment-id header?

3 participants