Skip to content

chore: run Svelte 5 tests in loose parser mode #2652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dummdidumm merged 1 commit into from
Jan 6, 2025
Merged

chore: run Svelte 5 tests in loose parser mode #2652

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions packages/svelte2tsx/test/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ export class Sample {

constructor(
dir: string,
readonly name: string
readonly name: string,
public emitOnTemplateError = false
) {
this.directory = path.resolve(dir, 'samples', name);
this.folder = fs.readdirSync(this.directory);
Expand Down Expand Up @@ -110,7 +111,7 @@ export class Sample {

const sample = this;

_it(this.name, function () {
_it(this.name + (this.emitOnTemplateError ? ' (loose parser mode)' : ''), function () {
try {
fn();
if (sample.skipped) this.skip();
Expand Down Expand Up @@ -237,7 +238,7 @@ export function test_samples(dir: string, transform: TransformSampleFn, js: 'js'
const config = {
filename: svelteFile,
sampleName: sample.name,
emitOnTemplateError: false,
emitOnTemplateError: sample.emitOnTemplateError,
preserveAttributeCase: sample.name.endsWith('-foreign-ns')
};

Expand Down Expand Up @@ -382,6 +383,9 @@ export function get_svelte2tsx_config(base: BaseConfig, sampleName: string): Sve
export function* each_sample(dir: string) {
for (const name of fs.readdirSync(`${dir}/samples`)) {
yield new Sample(dir, name);
if (isSvelte5Plus && !fs.existsSync(`${dir}/samples/${name}/expected.error.json`)) {
yield new Sample(dir, `${name}`, true);
}
}
}

Expand Down
Loading