fix: prevent config loading message in svelte-check --incremental#2974
Open
jasonlyu123 wants to merge 2 commits intomasterfrom
Open
fix: prevent config loading message in svelte-check --incremental#2974jasonlyu123 wants to merge 2 commits intomasterfrom
jasonlyu123 wants to merge 2 commits intomasterfrom
Conversation
🦋 Changeset detectedLatest commit: 1b02436 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dummdidumm
reviewed
Mar 18, 2026
| public url: string, | ||
| public content: string | ||
| public content: string, | ||
| loadConfig = false |
Member
There was a problem hiding this comment.
shouldn't we do it the other way around? load config by default. I think this would result in less changed code locations.
Member
Author
There was a problem hiding this comment.
There are a lot of new Document calls in the test, and most of them don't need the config. But the performance difference in config loading during the test isn't very noticeable, so it's not that important. Would you prefer it to be skipLoadConfig instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2972
Setting the log level should be enough for this. But the config won't be used here, so might as well add an option to skip loading. The default is to skip it since most tests won't use the config either.