fix: close SSE stream immediately #14
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the SSE stream sits basically unused (since it's really only used for list changed notification and logging, both of which we don't even have in the capabilities). But since we are hosting on Vercel, it times out after 300 seconds, leaving a nasty log in the observability panel.
Doing this will immediately close the stream and return an empty string (or the MCP inspector will yell at us) so that we don't waste Vercel resources and we don't have nasty logs.
The downside is obviously that if, in the future, we want to send notifications or logs, we have to remember to re-enable it.
Btw, testing this I:
I would say this is good for the moment, but I want to hear if anybody is against it.