Skip to content

perf: iterate children using a for loop #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2025
+22 −22
Merged

perf: iterate children using a for loop #694

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 22 additions & 22 deletions src/parser/converts/block.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,17 +147,17 @@ export function convertIfBlock(
});
const consequent = getConsequentFromIfBlock(node);

ifBlock.children.push(
...convertChildren(
{
nodes:
// Adjust for Svelte v5
trimChildren(getChildren(consequent)),
},
ifBlock,
ctx,
),
);
for (const child of convertChildren(
{
nodes:
// Adjust for Svelte v5
trimChildren(getChildren(consequent)),
},
ifBlock,
ctx,
)) {
ifBlock.children.push(child);
}

ctx.scriptLet.closeScope();
if (elseif) {
Expand Down Expand Up @@ -218,17 +218,17 @@ export function convertIfBlock(
ifBlock.else = elseBlock;

ctx.scriptLet.nestBlock(elseBlock);
elseBlock.children.push(
...convertChildren(
{
nodes:
// Adjust for Svelte v5
trimChildren(elseChildren),
},
elseBlock,
ctx,
),
);
for (const child of convertChildren(
{
nodes:
// Adjust for Svelte v5
trimChildren(elseChildren),
},
elseBlock,
ctx,
)) {
elseBlock.children.push(child);
}
ctx.scriptLet.closeScope();
extractMustacheBlockTokens(elseBlock, ctx, { startOnly: true });

Expand Down
Loading