respect system theme, without FOUC #1087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
PuruVJ
reviewed
Jan 16, 2025
| /> | ||
|
|
||
| <script> | ||
| document.documentElement.classList.add( |
There was a problem hiding this comment.
You do need this to avoid/minimize the FOUC
There was a problem hiding this comment.
no you don't, it's injected via ThemeToggle.svelte
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #1076 — unlike that PR, this one prevents FOUC.
It also overhauls theme management in a few other ways:
Persistedclass which serves the same purpose assvelte-persisted-store, but without using storesPersistedto create aThemeclassThemeToggle.sveltecomponentThe result is that the code is more self-contained and easier to maintain. Eventually, we can probably get rid of the dependency on
svelte-persisted-storealtogether